Skip to content

Commit fda2a02

Browse files
authored
Merge pull request #71 from moufmouf/oracle_aliases
In Oracle, table aliases cannot contain the AS keyword
2 parents 79e9211 + 8505ee3 commit fda2a02

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/SQLParser/Node/Table.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ public function toSql(array $parameters, AbstractPlatform $platform, int $indent
229229
}
230230
$sql .= $platform->quoteSingleIdentifier($this->table);
231231
if ($this->alias) {
232-
$sql .= ' AS '.$platform->quoteSingleIdentifier($this->alias);
232+
$sql .= ' '.$platform->quoteSingleIdentifier($this->alias);
233233
}
234234
if ($this->hints) {
235235
foreach ($this->hints as $hint) {

tests/Mouf/Database/MagicQueryTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,10 +189,10 @@ public function testStandardSelect()
189189
$this->assertEquals('SELECT a FROM users UNION SELECT a FROM users', self::simplifySql($magicQuery->build($sql)));
190190

191191
$sql = 'SELECT a FROM users u, users u2';
192-
$this->assertEquals('SELECT a FROM users AS u CROSS JOIN users AS u2', self::simplifySql($magicQuery->build($sql)));
192+
$this->assertEquals('SELECT a FROM users u CROSS JOIN users u2', self::simplifySql($magicQuery->build($sql)));
193193

194194
$sql = 'SELECT a FROM users u WHERE status = (CASE WHEN u.id = 1 THEN u.status_1 ELSE u.status_2 END)';
195-
$this->assertEquals('SELECT a FROM users AS u WHERE status = (CASE WHEN u.id = 1 THEN u.status_1 ELSE u.status_2 END)', self::simplifySql($magicQuery->build($sql)));
195+
$this->assertEquals('SELECT a FROM users u WHERE status = (CASE WHEN u.id = 1 THEN u.status_1 ELSE u.status_2 END)', self::simplifySql($magicQuery->build($sql)));
196196

197197
$sql = 'SELECT 42 as fooalias FROM bar HAVING fooalias = 24';
198198
$this->assertEquals('SELECT 42 AS fooalias FROM bar HAVING fooalias = 24', self::simplifySql($magicQuery->build($sql)));

0 commit comments

Comments
 (0)