fix: migration and theme layout issues #218
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: migration and theme layout issues
What kind of change does this PR introduce? (pls check at least one)
Description
Issue 1
Since the
users
androles
tables are referenced by other tables, directly deleting their data results in a fatal error. This occurs because most db engines, by default, enforce constraint checks to maintain referential integrity.To resolve this, I've disabled foreign key checks before truncating the tables. This allows to clear the data without encountering errors related to foreign key constraints.
Issue 2
added content
x-app.container-full
since there was no associated markup with itIssue 3
x-app.heading
it doesn't make sense to use null coalescing (??) for the same values that are already defined in @props.Why?
x-app.heading
, the slot can also be dynamically toggled to allows it's elements to be accessed via a dropdown on mobile devices or smaller screens, ensuring a clean and intuitive UI.Other Suggestions
Use the
truncate
method instead ofdelete
for the seeders to cleer all records in the tables. Thetruncate
method is more efficient for this purpose, as it doesn't log individual row deletions and can be faster than a standard delete operation and autoincrement is reset, which is not the case withdelete
.Does this PR introduce a breaking change? (check one)
cc @bobbyiliev