Drop register-in-foreman option from install message output #1012
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ekohl
reviewed
Feb 24, 2025
There was a problem hiding this comment.
👍 for removal, but it's also mentioned in https://github.com/theforeman/foreman-installer/blob/develop/KATELLO.md. Even though we don't really maintain it, I'd prefer to remove any mentions. Once merged, we can revisit theforeman/foreman-documentation#3080.
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
ehelms
force-pushed
the
drop-register-in-foreman
branch
from
8c426f9 to
177bb70
Compare
ekohl
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for
--foreman-proxy-register-in-foremanis true in the puppet module, so this option is not needed in the output.