SAT-30393 - Skip recurring logic tasks if on prem is enabled

theforeman · Jan 14, 2025 · 01f3c72 · 01f3c72
1 parent d8d9703
commit 01f3c72
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 0 deletions.
diff --git a/lib/foreman_inventory_upload/async/generate_all_reports_job.rb b/lib/foreman_inventory_upload/async/generate_all_reports_job.rb
@@ -5,6 +5,13 @@ class GenerateAllReportsJob < ::Actions::EntryAction
       include ForemanInventoryUpload::Async::DelayedStart
 
       def plan
+        if ForemanRhCloud.with_local_advisor_engine?
+          logger.debug(
+            'The scheduled process is disabled due to the "use_local_advisor_engine"
+            SETTING being set to true.'
+          )
+          return
+        end
         unless Setting[:allow_auto_inventory_upload]
           logger.debug(
             'The scheduled process is disabled due to the "allow_auto_inventory_upload"

diff --git a/lib/foreman_rh_cloud/engine.rb b/lib/foreman_rh_cloud/engine.rb
@@ -193,4 +193,8 @@ def self.register_scheduled_task(task_class, cronline)
       end
     end
   end
+
+  def self.with_local_advisor_engine?
+    SETTINGS.dig(:foreman_rh_cloud, :use_local_advisor_engine) || false
+  end
 end
diff --git a/lib/insights_cloud/async/insights_scheduled_sync.rb b/lib/insights_cloud/async/insights_scheduled_sync.rb
@@ -5,6 +5,13 @@ class InsightsScheduledSync < ::Actions::EntryAction
       include ForemanInventoryUpload::Async::DelayedStart
 
       def plan
+        if ForemanRhCloud.with_local_advisor_engine?
+          logger.debug(
+            'The scheduled process is disabled due to the "use_local_advisor_engine"
+            SETTING being set to true.'
+          )
+          return
+        end
         unless Setting[:allow_auto_insights_sync]
           logger.debug(
             'The scheduled process is disabled due to the "allow_auto_insights_sync"

diff --git a/lib/inventory_sync/async/inventory_scheduled_sync.rb b/lib/inventory_sync/async/inventory_scheduled_sync.rb
@@ -5,6 +5,13 @@ class InventoryScheduledSync < ::Actions::EntryAction
       include ForemanInventoryUpload::Async::DelayedStart
 
       def plan
+        if ForemanRhCloud.with_local_advisor_engine?
+          logger.debug(
+            'The scheduled process is disabled due to the "use_local_advisor_engine"
+            SETTING being set to true.'
+          )
+          return
+        end
         unless Setting[:allow_auto_inventory_upload]
           logger.debug(
             'The scheduled process is disabled due to the "allow_auto_inventory_upload"

diff --git a/test/jobs/inventory_scheduled_sync_test.rb b/test/jobs/inventory_scheduled_sync_test.rb
@@ -31,4 +31,13 @@ class InventoryScheduledSyncTest < ActiveSupport::TestCase
 
     ForemanTasks.sync_task(InventorySync::Async::InventoryScheduledSync)
   end
+
+  test 'Skips execution if local advisor engine is enabled' do
+    Setting[:allow_auto_inventory_upload] = false
+    ForemanRhCloud.stubs(:with_local_advisor_engine?).returns(true)
+
+    InventorySync::Async::InventoryScheduledSync.any_instance.expects(:plan_org_sync).never
+
+    ForemanTasks.sync_task(InventorySync::Async::InventoryScheduledSync)
+  end
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -193,4 +193,8 @@ def self.register_scheduled_task(task_class, cronline) @@
           end
         end
       end
+      def self.with_local_advisor_engine?
+        SETTINGS.dig(:foreman_rh_cloud, :use_local_advisor_engine) || false
+      end
     end