-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreman RH Cloud API Bindings to upload hits #933
Merged
Merged
+248
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c22cda5
to
b630dec
Compare
evgeni
reviewed
Jan 9, 2025
app/controllers/api/v2/insights_advisor/insights_advisor_controller.rb
Outdated
Show resolved
Hide resolved
evgeni
reviewed
Jan 10, 2025
app/controllers/api/v2/insights_advisor/insights_advisor_controller.rb
Outdated
Show resolved
Hide resolved
evgeni
reviewed
Jan 10, 2025
app/controllers/api/v2/insights_advisor/insights_advisor_controller.rb
Outdated
Show resolved
Hide resolved
a569462
to
7dd62c4
Compare
jeremylenz
reviewed
Jan 15, 2025
app/controllers/api/v2/advisor_engine/advisor_engine_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/api/v2/advisor_engine/advisor_engine_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/api/v2/advisor_engine/advisor_engine_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/api/v2/advisor_engine/advisor_engine_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/api/v2/advisor_engine/advisor_engine_controller.rb
Outdated
Show resolved
Hide resolved
44bbbb7
to
aa43cb7
Compare
chris1984
reviewed
Jan 16, 2025
chris1984
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works well with the steps in the downstream readme once the container came up.
jeremylenz
reviewed
Jan 17, 2025
app/controllers/api/v2/advisor_engine/advisor_engine_controller.rb
Outdated
Show resolved
Hide resolved
ff0ba10
to
ffc577b
Compare
jeremylenz
reviewed
Jan 17, 2025
e14fad4
to
0b8cee3
Compare
Co-authored-by: Evgeni Golov <evgeni@golov.de> Co-authored-by: Jeremy Lenz <jlenz@redhat.com> Add unit tests
0b8cee3
to
a34421e
Compare
jeremylenz
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.