Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trusted publishers to release gems #949

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Use trusted publishers to release gems #949

merged 1 commit into from
Feb 11, 2025

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 11, 2025

chris1984
chris1984 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the RFC you wrote, and it makes sense and long term it will be nice to have release workflows locked down more for security.

@chris1984 chris1984 merged commit cceee6e into theforeman:develop Feb 11, 2025
12 checks passed
@ekohl ekohl deleted the trusted-publisher branch February 11, 2025 16:58
@ekohl
Copy link
Member Author

ekohl commented Feb 11, 2025

  • Created the trusted publisher on Rubygems
  • Deleted old GH secret
  • Deleted old API key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohl @chris1984