Skip to content

Fixes #38294 - Remove oVirt #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos changed the title [WIP] Fixes #38266 - Remove oVirt [WIP] Remove oVirt Mar 17, 2025
@stejskalleos stejskalleos marked this pull request as ready for review April 1, 2025 08:02
@stejskalleos stejskalleos changed the title [WIP] Remove oVirt Remove oVirt Apr 1, 2025
@stejskalleos
Copy link
Contributor Author

The only failing test is this one:

parameters::remove-interface#test_0004_should remove interface [test/functional/compute_attribute_test.rb:651]:
--- expected
+++ actual
@@ -1 +1,3 @@
-""
+"Could not remove interface:
+  Error: undefined method `has_key?' for nil:NilClass
+"

Not sure why it doesn't work with Libvirt compute resource, need to take a look.

@stejskalleos stejskalleos requested a review from ofedoren April 1, 2025 10:57
@ofedoren ofedoren changed the title Remove oVirt Fixes #38294 - Remove oVirt Apr 2, 2025
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stejskalleos, I guess this should wait until the same logic was removed from the core?

Regarding failing test, please see inline, that should fix it.

@stejskalleos
Copy link
Contributor Author

I guess this should wait until the same logic was removed from the core?

Correct, this is for the 3.16 release. I just want to make sure everything is ready so we can merge the PR right after the branching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants