Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📃 Fix example to work better with deno doc and lsp #875

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Jan 2, 2024

Motivation

The examples in the docs were not rendering properly on the deno doc site, and also inside the LSP for a number of reasons.

Borked language highlighting:

image

Captions don't seem to work

image

Approach

This normalizes how examples are identified:

  • use fully qualified language name. I.e. "javascript" instead of "js"
  • remove any captions

The examples in the docs were not rendering properly on the deno doc
site, and also inside the LSP for a number of reasons.

This normalizes how examples are identified:

- use fully qualified language name. I.e. "javascript" instead of "js"
- remove any captions
@cowboyd cowboyd merged commit b8f8c44 into v3 Jan 2, 2024
1 check passed
@cowboyd cowboyd deleted the example-fixes branch January 2, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants