Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 resolve operation overload before simple function overload #973

Merged
merged 1 commit into from
Feb 14, 2025
Merged

🐛 resolve operation overload before simple function overload #973

merged 1 commit into from
Feb 14, 2025

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Feb 10, 2025

Motivation

fix #972

@cowboyd cowboyd requested review from taras and jbolda February 10, 2025 22:37
taras
taras approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only a problem in V4?

@cowboyd
Copy link
Member Author

cowboyd commented Feb 10, 2025 •
edited
Loading

@taras good question. I don't think so, although e3 prioritizes Operation functions over async functions 🤷🏻

https://github.com/thefrontside/effection/blob/v3/lib/call.ts#L95-L102

@taras taras merged commit a511636 into v4 Feb 14, 2025
5 checks passed
@taras taras deleted the fix-call-types branch February 14, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taras taras taras approved these changes

@jbolda jbolda Awaiting requested review from jbolda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cowboyd @taras