Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Match scoped packages for NPM publish #296

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Sep 17, 2024

Motivation

According to the github docs * will match multiple characters but not / which means *-v* will not match @interactors/html-v1.0.1

Approach

Match the package name with **

According to the [github
docs](https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet)
`*` will match multiple characters but not `/` which means `*-v*` will
not match `@interactors/html-v1.0.1`

This changes `*` to `**` so that it should match.
@cowboyd cowboyd requested a review from jbolda September 17, 2024 19:58
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for interactors canceled.

Name Link
🔨 Latest commit a2657ee
🔍 Latest deploy log https://app.netlify.com/sites/interactors/deploys/66e9df6f527b340008b84763

Copy link
Contributor

Package Changes Through a2657ee

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@cowboyd cowboyd merged commit 326f1cb into main Sep 17, 2024
6 checks passed
@cowboyd cowboyd deleted the cl/tag-match-on-publish branch September 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants