Fix bug when no keyword association is selected on update

Author: mespeche

Action/Keyword.php

@@ -68,15 +68,17 @@ public function updateKeywordFolderAssociation(KeywordAssociationEvent $event)
             ->filterByFolderId($folder->getId())
             ->delete();
 
-        // Create all associations to this folder
-        foreach ($keywordListToSave as $keywordId) {
+        if ($keywordListToSave !== null) {
+            // Create all associations to this folder
+            foreach ($keywordListToSave as $keywordId) {
 
-            $keywordFolderAssociation = new FolderAssociatedKeyword();
-            $keywordFolderAssociation
-                ->setFolderId($folder->getId())
-                ->setKeywordId($keywordId)
-                ->save();
+                $keywordFolderAssociation = new FolderAssociatedKeyword();
+                $keywordFolderAssociation
+                    ->setFolderId($folder->getId())
+                    ->setKeywordId($keywordId)
+                    ->save();
 
+            }
         }
 
     }
@@ -94,15 +96,17 @@ public function updateKeywordContentAssociation(KeywordAssociationEvent $event)
             ->filterByContentId($content->getId())
             ->delete();
 
-        // Create all associations to this folder
-        foreach ($keywordListToSave as $keywordId) {
+        if ($keywordListToSave !== null) {
+            // Create all associations to this folder
+            foreach ($keywordListToSave as $keywordId) {
 
-            $keywordFolderAssociation = new ContentAssociatedKeyword();
-            $keywordFolderAssociation
-                ->setContentId($content->getId())
-                ->setKeywordId($keywordId)
-                ->save();
+                $keywordFolderAssociation = new ContentAssociatedKeyword();
+                $keywordFolderAssociation
+                    ->setContentId($content->getId())
+                    ->setKeywordId($keywordId)
+                    ->save();
 
+            }
         }
 
     }
@@ -120,15 +124,17 @@ public function updateKeywordCategoryAssociation(KeywordAssociationEvent $event)
             ->filterByCategoryId($category->getId())
             ->delete();
 
-        // Create all associations to this category
-        foreach ($keywordListToSave as $keywordId) {
+        if ($keywordListToSave !== null) {
+            // Create all associations to this category
+            foreach ($keywordListToSave as $keywordId) {
 
-            $keywordCategoryAssociation = new CategoryAssociatedKeyword();
-            $keywordCategoryAssociation
-                ->setCategoryId($category->getId())
-                ->setKeywordId($keywordId)
-                ->save();
+                $keywordCategoryAssociation = new CategoryAssociatedKeyword();
+                $keywordCategoryAssociation
+                    ->setCategoryId($category->getId())
+                    ->setKeywordId($keywordId)
+                    ->save();
 
+            }
         }
 
     }
@@ -146,15 +152,17 @@ public function updateKeywordProductAssociation(KeywordAssociationEvent $event)
             ->filterByProductId($product->getId())
             ->delete();
 
-        // Create all associations to this folder
-        foreach ($keywordListToSave as $keywordId) {
+        if ($keywordListToSave !== null) {
+            // Create all associations to this folder
+            foreach ($keywordListToSave as $keywordId) {
 
-            $keywordProductAssociation = new ProductAssociatedKeyword();
-            $keywordProductAssociation
-                ->setProductId($product->getId())
-                ->setKeywordId($keywordId)
-                ->save();
+                $keywordProductAssociation = new ProductAssociatedKeyword();
+                $keywordProductAssociation
+                    ->setProductId($product->getId())
+                    ->setKeywordId($keywordId)
+                    ->save();
 
+            }
         }
 
     }

Config/module.xml

@@ -7,7 +7,7 @@
     <descriptive locale="en_US">
         <title>Keyword</title>
     </descriptive>
-    <version>2.4.2</version>
+    <version>2.4.3</version>
     <author>
         <name>Michaël Espeche</name>
         <email>mespeche@openstudio.fr</email>