Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Secrets Manager and AWS secret environment variable refactoring, possible impacts ? #2

Open
Benvii opened this issue Sep 2, 2024 · 0 comments

Comments

@Benvii
Copy link
Member

Benvii commented Sep 2, 2024

Based on this design several changes in environment variable may have impacts on these helm charts (I'm not 100% sure as this helm charts doesn't rely on cloud services).

theopenconversationkit/tock#1697

I'm creating this ticket so that someone can read the merged design and determine if there are impacts.

@Benvii Benvii changed the title GCP Secrets Manager and AWS secret environment variable refactoring GCP Secrets Manager and AWS secret environment variable refactoring, possible impacts ? Sep 2, 2024
sacquatella added a commit that referenced this issue Feb 3, 2025
- Add secret parameters in configmap
vsct-jburet pushed a commit that referenced this issue Feb 13, 2025
* upgrade to tock 24.9.4

* update readme

* solve issue link to bad authConfigfMap typo

* clean

* Set a default value for vectorstore provider

If no value genai_orchestrator doesn't start

* Upgrade to version 24.9.4

Add tock_web_connector_extra_headers params in bot_api configmap

* Solve #2  Secrets Manager

- Add secret parameters in configmap

* use null value vs "null" as default value for secret manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant