Bindings: Fix chat template fetching

Make sure to write the metadata key to the buffer and return it. Also,
fix error handling when loading a template from the model.

Signed-off-by: kingbri <8082010+kingbri1@users.noreply.github.com>

Author: kingbri1

bindings/binding.cpp

@@ -41,7 +41,20 @@ char* GetModelChatTemplate(const llama_model* model) {
     static const char* tokenizerTemplateKey = "tokenizer.chat_template";
     const int32_t bufSize = llama_model_meta_val_str(model, tokenizerTemplateKey, nullptr, 0) + 1;
 
+    // Return null if template doesn't exist
+    if (bufSize <= 1) {
+        return nullptr;
+    }
+
     const auto buffer = new char[bufSize];
+    llama_model_meta_val_str(model, tokenizerTemplateKey, buffer, bufSize);
+
+    // Additional check to see if the buffer has data
+    if (buffer[0] == '\0') {
+        delete[] buffer;
+        return nullptr;
+    }
+
     return buffer;
 }
 

bindings/bindings.ts

@@ -526,9 +526,8 @@ export class Model {
                 }
             } catch (error) {
                 if (error instanceof Error) {
-                    logger.warn(
-                        `${error.stack} \nAttempting next template method.`,
-                    );
+                    logger.error(error.stack);
+                    logger.warn("Attempting next template method.");
                 }
             }
         }
@@ -539,7 +538,8 @@ export class Model {
             );
         } else {
             logger.warn(
-                "Could not create a prompt template because of the above errors\n " +
+                "Could not create a prompt template because of the above errors.\n" +
+                    "Chat completions are disabled.\n" +
                     "YALS will continue loading without the prompt template.\n" +
                     "Please proofread the template and make sure it's compatible " +
                     "with huggingface's jinja subset.",
@@ -892,7 +892,7 @@ export class Model {
         });
 
         if (templatePtr === null) {
-            throw new Error("Failed to get model chat template from model");
+            throw new Error("No chat template found in model");
         }
 
         // Copy to owned string