[fix] [txn] Get previous position by managed ledger. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
…Doc (apache#21980) Co-authored-by: Matteo Merli <mmerli@apache.org>
…22022) ### Motivation For some use case, the users need to store all the messages even though these message are acked by all subscription. So they set the retention policy of the namespace to infinite retention (setting both time and size limits to `-1`). But the data in the system topic does not need for infinite retention. ### Modifications For system topics, do not retain messages that have already been acknowledged.
…addTransaction (apache#22020) ### Motivation According to the method signature, we should return true when the transaction is added to the tracker. ``` /** * Add a txnID to the tracker. * * @param sequenceId * the sequenceId * @param timeout * the absolute timestamp for transaction timeout * * @return true if the transaction was added to the tracker or false if had timed out */ CompletableFuture<Boolean> addTransaction(long sequenceId, long timeout); ``` But actually, we return false for any cases. Update: Moreover, we do not use the return value anyway, it is useless. We have better remove it. ### Modifications ~~Return true when the transaction is added to the tracker.~~ Remove the return value as it is useless.
Co-authored-by: Zac Bentley <zbentley@users.noreply.github.com>
Co-authored-by: Matteo Merli <mmerli@apache.org>
…-io/solr (apache#22047) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- https://learn.microsoft.com/en-us/azure/data-explorer/ Co-authored-by: Ramachandran A G <106139410+ag-ramachandran@users.noreply.github.com>
…rting broker registry. (apache#22065)
…-404` when calling `Admin API` and the topic does not exist. (apache#21995)
… in expiryMon… (apache#21991) Co-authored-by: atomchchen <atomchchen@tencent.com>
thetumbled
force-pushed
the
Fix_MaxReadPosition
branch
from
faf485b to
b9b8913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache#22024