Skip to content

Commit b2db827

Browse files
authored
Erc20bases update: remove _contractURI from constructor params (#227)
* remove _contractURI from constructor params * update tests * run prettier
1 parent a636185 commit b2db827

12 files changed

+10
-26
lines changed

contracts/base/ERC20Base.sol

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,7 @@ contract ERC20Base is ContractMetadata, Multicall, Ownable, ERC20Permit {
2727
Constructor
2828
//////////////////////////////////////////////////////////////*/
2929

30-
constructor(
31-
string memory _name,
32-
string memory _symbol,
33-
string memory _contractURI
34-
) ERC20Permit(_name, _symbol) {
35-
_setupContractURI(_contractURI);
30+
constructor(string memory _name, string memory _symbol) ERC20Permit(_name, _symbol) {
3631
_setupOwner(msg.sender);
3732
}
3833

contracts/base/ERC20Drop.sol

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,8 @@ contract ERC20Drop is ContractMetadata, Multicall, Ownable, ERC20Permit, Primary
3939
constructor(
4040
string memory _name,
4141
string memory _symbol,
42-
string memory _contractURI,
4342
address _primarySaleRecipient
4443
) ERC20Permit(_name, _symbol) {
45-
_setupContractURI(_contractURI);
4644
_setupOwner(msg.sender);
4745
_setupPrimarySaleRecipient(_primarySaleRecipient);
4846
}

contracts/base/ERC20DropVote.sol

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,8 @@ contract ERC20DropVote is ContractMetadata, Multicall, Ownable, ERC20Votes, Prim
3939
constructor(
4040
string memory _name,
4141
string memory _symbol,
42-
string memory _contractURI,
4342
address _primarySaleRecipient
4443
) ERC20Permit(_name, _symbol) {
45-
_setupContractURI(_contractURI);
4644
_setupOwner(msg.sender);
4745
_setupPrimarySaleRecipient(_primarySaleRecipient);
4846
}

contracts/base/ERC20SignatureMint.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,8 @@ contract ERC20SignatureMint is ERC20Base, PrimarySale, SignatureMintERC20 {
2929
constructor(
3030
string memory _name,
3131
string memory _symbol,
32-
string memory _contractURI,
3332
address _primarySaleRecipient
34-
) ERC20Base(_name, _symbol, _contractURI) {
33+
) ERC20Base(_name, _symbol) {
3534
_setupPrimarySaleRecipient(_primarySaleRecipient);
3635
}
3736

contracts/base/ERC20SignatureMintVote.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,8 @@ contract ERC20SignatureMintVote is ERC20Vote, PrimarySale, SignatureMintERC20 {
2929
constructor(
3030
string memory _name,
3131
string memory _symbol,
32-
string memory _contractURI,
3332
address _primarySaleRecipient
34-
) ERC20Vote(_name, _symbol, _contractURI) {
33+
) ERC20Vote(_name, _symbol) {
3534
_setupPrimarySaleRecipient(_primarySaleRecipient);
3635
}
3736

contracts/base/ERC20Vote.sol

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,7 @@ contract ERC20Vote is ContractMetadata, Multicall, Ownable, ERC20Votes {
2727
Constructor
2828
//////////////////////////////////////////////////////////////*/
2929

30-
constructor(
31-
string memory _name,
32-
string memory _symbol,
33-
string memory _contractURI
34-
) ERC20Permit(_name, _symbol) {
35-
_setupContractURI(_contractURI);
30+
constructor(string memory _name, string memory _symbol) ERC20Permit(_name, _symbol) {
3631
_setupOwner(msg.sender);
3732
}
3833

src/test/sdk/base/ERC20Base.t.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ contract BaseERC20BaseTest is BaseUtilTest {
2323
function setUp() public override {
2424
super.setUp();
2525
vm.prank(deployer);
26-
base = new ERC20Base(NAME, SYMBOL, CONTRACT_URI);
26+
base = new ERC20Base(NAME, SYMBOL);
2727

2828
recipient = vm.addr(recipientPrivateKey);
2929

src/test/sdk/base/ERC20Drop.t.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ contract BaseERC20DropTest is BaseUtilTest {
2525
function setUp() public override {
2626
super.setUp();
2727
vm.prank(signer);
28-
base = new ERC20Drop(NAME, SYMBOL, CONTRACT_URI, saleRecipient);
28+
base = new ERC20Drop(NAME, SYMBOL, saleRecipient);
2929

3030
recipient = vm.addr(recipientPrivateKey);
3131
erc20.mint(recipient, 1_000_000 ether);

src/test/sdk/base/ERC20DropVote.t.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ contract BaseERC20DropVoteTest is BaseUtilTest {
2626
function setUp() public override {
2727
super.setUp();
2828
vm.prank(signer);
29-
base = new ERC20DropVote(NAME, SYMBOL, CONTRACT_URI, saleRecipient);
29+
base = new ERC20DropVote(NAME, SYMBOL, saleRecipient);
3030

3131
recipient = vm.addr(recipientPrivateKey);
3232
erc20.mint(recipient, 1_000_000 ether);

src/test/sdk/base/ERC20SignatureMint.t.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ contract BaseERC20SignatureMintTest is BaseUtilTest {
2525
function setUp() public override {
2626
super.setUp();
2727
vm.prank(signer);
28-
base = new ERC20SignatureMint(NAME, SYMBOL, CONTRACT_URI, saleRecipient);
28+
base = new ERC20SignatureMint(NAME, SYMBOL, saleRecipient);
2929

3030
recipient = address(0x123);
3131
erc20.mint(recipient, 1_000_000 ether);

src/test/sdk/base/ERC20SignatureMintVote.t.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ contract BaseERC20SignatureMintVoteTest is BaseUtilTest {
2525
function setUp() public override {
2626
super.setUp();
2727
vm.prank(signer);
28-
base = new ERC20SignatureMintVote(NAME, SYMBOL, CONTRACT_URI, saleRecipient);
28+
base = new ERC20SignatureMintVote(NAME, SYMBOL, saleRecipient);
2929

3030
recipient = address(0x123);
3131
erc20.mint(recipient, 1_000 ether);

src/test/sdk/base/ERC20Vote.t.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ contract BaseERC20VoteTest is BaseUtilTest {
2424
function setUp() public override {
2525
super.setUp();
2626
vm.prank(deployer);
27-
base = new ERC20Vote(NAME, SYMBOL, CONTRACT_URI);
27+
base = new ERC20Vote(NAME, SYMBOL);
2828

2929
recipient = vm.addr(recipientPrivateKey);
3030

0 commit comments

Comments
 (0)