fix all biome errors (#815)

* bump yarn to berry

* fix all biome errors

* bring back pinned resolved deps, fix whitepsace

---------

Co-authored-by: Phillip Ho <arcoraven@gmail.com>

Author: 2 people

.github/workflows/build-image-tag.yml

@@ -14,7 +14,7 @@ jobs:
       matrix:
         include:
           - platform: linux/amd64
-            runner: ubuntu-latest
+            runner: ubuntu-24.04
             arch: amd64
           - platform: linux/arm64
             runner: ubuntu-24.04-arm64
@@ -53,7 +53,7 @@ jobs:
 
   merge-manifests:
     needs: build
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     env:
       LATEST_TAG: ${{ github.event.release.target_commitish == 'main' && 'thirdweb/engine:latest' || '' }}
     steps:

.github/workflows/build.yml

@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -16,7 +16,7 @@ jobs:
         with:
           node-version: "18"
           cache: "yarn"
-  
+
       - name: Install dependencies
         run: yarn install
 

.github/workflows/lint.yml

@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   lint:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -16,7 +16,7 @@ jobs:
         with:
           node-version: "18"
           cache: "yarn"
-  
+
       - name: Install dependencies
         run: yarn install
 

.github/workflows/main.yml

@@ -15,7 +15,7 @@ jobs:
       matrix:
         include:
           - platform: linux/amd64
-            runner: ubuntu-latest
+            runner: ubuntu-24.04
             arch: amd64
           - platform: linux/arm64
             runner: ubuntu-24.04-arm64
@@ -48,7 +48,7 @@ jobs:
 
   merge-manifests:
     needs: build
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3

.github/workflows/npm-publish.yml

@@ -5,7 +5,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@v4

.github/workflows/stale.yml

@@ -12,7 +12,7 @@ on:
 jobs:
   stale:
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     permissions:
       issues: write
       pull-requests: write

.yarnrc

@@ -1 +1 @@
---ignore-engines true
+--ignore-engines true

package.json

@@ -69,6 +69,7 @@
     "superjson": "^2.2.1",
     "thirdweb": "^5.71.0",
     "uuid": "^9.0.1",
+    "viem": "^2.21.54",
     "winston": "^3.14.1",
     "zod": "^3.23.8"
   },
@@ -94,8 +95,6 @@
   "resolutions": {
     "@thirdweb-dev/auth/**/axios": ">=1.7.8",
     "@thirdweb-dev/auth/**/web3-utils": ">=4.2.1",
-    "ethers-gcp-kms-signer/**/protobufjs": ">=7.2.5",
-    "fastify/**/find-my-way": ">=8.2.2",
     "@grpc/grpc-js": ">=1.8.22",
     "body-parser": ">=1.20.3",
     "cookie": ">=0.7.0",

src/polyfill.ts

@@ -1,5 +1,6 @@
 import * as crypto from "node:crypto";
 
 if (typeof globalThis.crypto === "undefined") {
-  (globalThis as any).crypto = crypto;
+  // @ts-expect-error
+  globalThis.crypto = crypto;
 }

src/server/listeners/update-tx-listener.ts

@@ -68,7 +68,7 @@ export const updateTxListener = async (): Promise<void> => {
     });
   });
 
-  connection.on("error", async (err: any) => {
+  connection.on("error", async (err: unknown) => {
     logger({
       service: "server",
       level: "error",

src/server/middleware/auth.ts

@@ -126,7 +126,7 @@ export async function withAuth(server: FastifyInstance) {
       }if (error) {
         message = error;
       }
-    } catch (err: any) {
+    } catch (err: unknown) {
       logger({
         service: "server",
         level: "warn",

src/server/middleware/error.ts

@@ -42,7 +42,7 @@ export const badChainError = (chain: string | number): CustomError =>
     "INVALID_CHAIN",
   );
 
-const flipObject = (data: any) =>
+const flipObject = (data: object) =>
   Object.fromEntries(Object.entries(data).map(([key, value]) => [value, key]));
 
 const isZodError = (err: unknown): boolean => {
@@ -72,15 +72,15 @@ export function withErrorHandler(server: FastifyInstance) {
             message: "code" in error ? error.code : error.message,
             reason: error.message,
             statusCode: 400,
-            stack: env.NODE_ENV !== "production" ? error.stack : undefined,
+            stack: env.NODE_ENV === "production" ? undefined : error.stack,
           },
         });
       }
 
       // Zod Typings Errors
       if (isZodError(error)) {
         const _error = error as ZodError;
-        let parsedMessage: any[] = [];
+        let parsedMessage: unknown;
 
         try {
           parsedMessage = JSON.parse(_error.message);
@@ -98,7 +98,7 @@ export function withErrorHandler(server: FastifyInstance) {
             message: errorObject.message ?? "Invalid Request",
             reason: errorObject ?? undefined,
             statusCode: 400,
-            stack: env.NODE_ENV !== "production" ? _error.stack : undefined,
+            stack: env.NODE_ENV === "production" ? undefined : _error.stack,
           },
         });
       }
@@ -118,7 +118,7 @@ export function withErrorHandler(server: FastifyInstance) {
             code,
             message,
             statusCode,
-            stack: env.NODE_ENV !== "production" ? error.stack : undefined,
+            stack: env.NODE_ENV === "production" ? undefined : error.stack,
           },
         });
       }
@@ -128,7 +128,7 @@ export function withErrorHandler(server: FastifyInstance) {
           statusCode: 500,
           code: "INTERNAL_SERVER_ERROR",
           message: error.message || ReasonPhrases.INTERNAL_SERVER_ERROR,
-          stack: env.NODE_ENV !== "production" ? error.stack : undefined,
+          stack: env.NODE_ENV === "production" ? undefined : error.stack,
         },
       });
     },

src/server/routes/backend-wallet/sign-transaction.ts

@@ -2,6 +2,7 @@ import { Type, type Static } from "@sinclair/typebox";
 import type { FastifyInstance } from "fastify";
 import { StatusCodes } from "http-status-codes";
 import type { Hex } from "thirdweb";
+import type { TransactionSerializable } from "viem";
 import { getAccount } from "../../../shared/utils/account";
 import {
   getChecksumAddress,
@@ -70,8 +71,7 @@ export async function signTransaction(fastify: FastifyInstance) {
         );
       }
 
-      // @TODO: Assert type to viem TransactionSerializable.
-      const serializableTransaction: any = {
+      const serializableTransaction = {
         chainId: transaction.chainId,
         to: getChecksumAddress(transaction.to),
         nonce: maybeInt(transaction.nonce),
@@ -86,7 +86,7 @@ export async function signTransaction(fastify: FastifyInstance) {
         maxFeePerGas: maybeBigInt(transaction.maxFeePerGas),
         maxPriorityFeePerGas: maybeBigInt(transaction.maxPriorityFeePerGas),
         ccipReadEnabled: transaction.ccipReadEnabled,
-      };
+      } as TransactionSerializable;
       const signature = await account.signTransaction(serializableTransaction);
 
       reply.status(StatusCodes.OK).send({

src/server/routes/contract/extensions/erc20/read/allowance-of.ts

@@ -67,7 +67,7 @@ export async function erc20AllowanceOf(fastify: FastifyInstance) {
         chainId,
         contractAddress,
       });
-      const returnData: any = await contract.erc20.allowanceOf(
+      const returnData = await contract.erc20.allowanceOf(
         ownerWallet ? ownerWallet : "",
         spenderWallet ? spenderWallet : "",
       );

src/server/routes/contract/extensions/erc20/read/get.ts

@@ -54,12 +54,12 @@ export async function erc20GetMetadata(fastify: FastifyInstance) {
         chainId,
         contractAddress,
       });
-      const returnData: any = await contract.erc20.get();
+      const returnData = await contract.erc20.get();
       reply.status(StatusCodes.OK).send({
         result: {
           symbol: returnData.symbol,
           name: returnData.name,
-          decimals: returnData.decimals,
+          decimals: returnData.decimals.toString(),
         },
       });
     },

src/server/routes/transaction/blockchain/send-signed-user-op.ts

@@ -8,6 +8,7 @@ import { TransactionHashSchema } from "../../../schemas/address";
 import { standardResponseSchema } from "../../../schemas/shared-api-schemas";
 import { walletChainParamSchema } from "../../../schemas/wallet";
 import { getChainIdFromChain } from "../../../utils/chain";
+import { prettifyError } from "../../../../shared/utils/error";
 
 const UserOp = Type.Object({
   sender: Type.String(),
@@ -86,10 +87,10 @@ export async function sendSignedUserOp(fastify: FastifyInstance) {
       if (typeof signedUserOp === "string") {
         try {
           userOp = Value.Decode(UserOpString, signedUserOp);
-        } catch (err: any) {
+        } catch (err) {
           return res.status(400).send({
             error: {
-              message: `Invalid signed user operation. - ${err.message || err}`,
+              message: `Invalid signed user operation. - ${prettifyError(err)}`,
             },
           });
         }

src/server/utils/convertor.ts

@@ -1,14 +1,13 @@
 import { BigNumber } from "ethers";
 
-export const bigNumberReplacer = (value: any): any => {
+const isHexBigNumber = (value: unknown) => {
+  const isNonNullObject = typeof value === "object" && value !== null;
+  const hasType = isNonNullObject && "type" in value;
+  return hasType && value.type === "BigNumber" && "hex" in value
+}
+export const bigNumberReplacer = (value: unknown): unknown => {
   // if we find a BigNumber then make it into a string (since that is safe)
-  if (
-    BigNumber.isBigNumber(value) ||
-    (typeof value === "object" &&
-      value !== null &&
-      value.type === "BigNumber" &&
-      "hex" in value)
-  ) {
+  if (BigNumber.isBigNumber(value) || isHexBigNumber(value)) {
     return BigNumber.from(value).toString();
   }
 

src/server/utils/wallets/get-aws-kms-account.ts

@@ -117,5 +117,5 @@ export async function getAwsKmsAccount(
     signMessage,
     signTypedData,
     signTransaction,
-  } satisfies Account;
+  } as AwsKmsAccount satisfies Account;
 }

src/server/utils/wallets/get-gcp-kms-account.ts

@@ -133,5 +133,5 @@ export async function getGcpKmsAccount(
     signMessage,
     signTypedData,
     signTransaction,
-  } satisfies Account;
+  } as GcpKmsAccount satisfies Account;
 }

src/shared/db/transactions/queue-tx.ts

@@ -9,7 +9,7 @@ import { parseTransactionOverrides } from "../../../server/utils/transaction-ove
 
 interface QueueTxParams {
   // we should move away from Transaction type (v4 SDK)
-  tx: Transaction<any> | DeployTransaction;
+  tx: Transaction<unknown> | DeployTransaction;
   chainId: number;
   extension: ContractExtension;
   // TODO: These shouldn't be in here

src/shared/lib/cache/swr.ts

@@ -75,7 +75,7 @@ export class SWRCache<K, V> {
   private set(key: K, data: V): void {
     if (this.cache.size >= this.options.maxEntries) {
       const firstKey = this.cache.keys().next().value;
-      this.cache.delete(firstKey);
+      this.cache.delete(firstKey as K);
     }
 
     this.cache.set(key, {

src/shared/utils/ethers.ts

@@ -20,7 +20,7 @@ export interface EthersError extends Error {
    *
    *  This is generally helpful mostly for human-based debugging.
    */
-  info?: Record<string, any>;
+  info?: Record<string, unknown>;
 
   /**
    *  Any related error.
@@ -35,17 +35,14 @@ export const ETHERS_ERROR_CODES = new Set(Object.values(ethers.errors));
  * @param error
  * @returns EthersError | null
  */
-export const parseEthersError = (error: any): EthersError | null => {
-  if (
-    error &&
-    typeof error === "object" &&
-    "code" in error &&
-    ETHERS_ERROR_CODES.has(error.code)
-  ) {
+export const parseEthersError = (error: unknown): EthersError | null => {
+  const isNonNullObject = error && typeof error === "object";
+  const hasCodeProperty = isNonNullObject && "code" in error;
+  if (hasCodeProperty && ETHERS_ERROR_CODES.has(error.code as ethers.errors)) {
     return error as EthersError;
   }
   return null;
 };
 
-export const isEthersErrorCode = (error: any, code: ethers.errors) =>
+export const isEthersErrorCode = (error: unknown, code: ethers.errors) =>
   parseEthersError(error)?.code === code;

src/shared/utils/logger.ts

@@ -59,7 +59,7 @@ const winstonLogger = createLogger({
     colorizeFormat(),
     format.printf(({ level, message, timestamp, error }) => {
       if (error) {
-        return `[${timestamp}] ${level}: ${message} - ${error.stack}`;
+        return `[${timestamp}] ${level}: ${message} - ${(error as Error).stack}`;
       }
       return `[${timestamp}] ${level}: ${message}`;
     }),
@@ -82,8 +82,8 @@ interface LoggerParams {
   level: (typeof env)["LOG_LEVEL"];
   message: string;
   queueId?: string | null;
-  error?: any;
-  data?: any;
+  error?: unknown;
+  data?: unknown;
 }
 
 export const logger = ({

src/shared/utils/transaction/simulate-queued-transaction.ts

@@ -1,3 +1,4 @@
+import { TransactionError } from "@thirdweb-dev/sdk";
 import {
   prepareTransaction,
   simulateTransaction,
@@ -70,7 +71,10 @@ export const doSimulateTransaction = async (
       account,
     });
     return null;
-  } catch (e: any) {
+  } catch (e: unknown) {
+    if (!(e instanceof TransactionError)) {
+      throw e;
+    }
     // Error should be of type TransactionError in the thirdweb SDK.
     return `${e.name}: ${e.message}`;
   }

src/shared/utils/transaction/types.ts

@@ -23,7 +23,7 @@ export type InsertedTransaction = {
 
   data?: Hex;
   functionName?: string;
-  functionArgs?: any[];
+  functionArgs?: unknown[];
 
   // User-provided overrides.
   overrides?: {