add gas to txOverrides #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're building your pull request over on Zeet. |
arcoraven
previously approved these changes
Apr 3, 2024
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
|
This PR needs more work. We only updated the Ingest to take in the |
arcoraven
dismissed
their stale review
This isn't setting the DB variable. LMK if this is needed, this one is a bit more involved.
* CICD for beta-nightly image (#481) * Updated Packages + UserOp Confirmation flow updated (#479) * Updated Packages + UserOp Confirmation flow updated * wallets sdk updated * fix: missing querystring + description upd (#486) * Added querystring to fastify route (#487) * fix: reject deprecated chains (#488) * chore: Allow cancelling txs that already errored (#491) * chore: Allow cancelling txs that already errored * clean up response * naming * update cancelledAt * fix: Cancel tx if populating a tx to retry fails (#493) * fix: Cancel tx if populating a tx to retry fails * ensure cancel uses high enough gas * fix build * combine prepare + send flows again * updates to GH flow, to use branch (#484) * updates to GH flow, to use branch * removed prelease incorrect tag * upds * got back tag creation check * upds * comments updated * final upds to handle the flow * Updated to use release::create for CI/CD image build/push flow * Updates to GH workflow to not push to if not release not from main (#495) * feat(experimental): Keypair auth (#494) * reorganize helper file * wip * support keypair auth * fix unit tests * return error messages for keypair auth errors * Don't catch JsonWebToken errors * catch access token * move public keys to db * fix: add crud endpoints * wip * add algorithm * add feature envvar * handle each jwt type separately * rename * remove expiration limit * Fix: Deploy Published Contract Flow (#499) * Updated Deploy Published Contract Flow + ProcessTx * removed commented lines * Updates * chore: add updated template for the railway (#490) * chore: add updated template for the railway Signed-off-by: Waren Gonzaga <opensource@warengonzaga.com> * chore: remove referral code Signed-off-by: Waren Gonzaga <opensource@warengonzaga.com> --------- Signed-off-by: Waren Gonzaga <opensource@warengonzaga.com> * Build fixes (#500) * Fix for Issue 502 (#505) * Added tx overrides for EOA + AA --------- Signed-off-by: Waren Gonzaga <opensource@warengonzaga.com> Co-authored-by: Phillip Ho <arcoraven@gmail.com> Co-authored-by: Waren Gonzaga <github@warengonzaga.com>
0xFirekeeper
approved these changes
Apr 19, 2024
farhanW3
reviewed
Apr 19, 2024
arcoraven
reviewed
Apr 19, 2024
Comment on lines
+177
to
+183
| } else { | ||
| // TODO: We need to target specific cases | ||
| // Bump gas limit to avoid occasional out of gas errors | ||
| txRequest.gasLimit = txRequest.gasLimit | ||
| ? BigNumber.from(txRequest.gasLimit).mul(120).div(100) | ||
| : undefined; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else { | |
| // TODO: We need to target specific cases | |
| // Bump gas limit to avoid occasional out of gas errors | |
| txRequest.gasLimit = txRequest.gasLimit | |
| ? BigNumber.from(txRequest.gasLimit).mul(120).div(100) | |
| : undefined; | |
| } | |
| } else if (txRequest.gasLimit) { | |
| // Use +20% gas limit to prevent occasional gas errors. | |
| txRequest.gasLimit = BigNumber.from(txRequest.gasLimit).mul(120).div(100) | |
| } |
There was a problem hiding this comment.
I believe this was added for shield (ran into issues running out of gas on airdrops). We could remove it and see if it returns?
arcoraven
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces gas-related enhancements to transaction processing, including gas limit overrides and gas price adjustments.
Detailed summary
gasfield to transaction overridesgas,maxFeePerGas, andmaxPriorityFeePerGasin transaction schemawrite.tsto include gas-related overridesqueueTxfunction to accepttxOverrideswith gas-related fieldsprocessTx.ts