Skip to content

Updated Error Response on API End-point #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

farhanW3
Copy link
Contributor

@farhanW3 farhanW3 commented May 14, 2024

PR-Codex overview

This PR adds custom error handling with status codes to various routes and improves logging for missed receipts/logs in worker tasks.

Detailed summary

  • Added custom error handling with status codes in multiple route files
  • Improved logging for missed receipts/logs in worker tasks

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@farhanW3 farhanW3 requested a review from arcoraven May 14, 2024 19:16
@@ -54,13 +58,15 @@ const handler: Processor<any, void, string> = async (job: Job<string>) => {
}

// Any logs inserted in a delayed job indicates missed logs in the realtime job.
if (job.delay > 0) {
if (job.opts.delay && job.opts.delay > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the first condition? Is opts.delay sometimes undefined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it can be undefined

@farhanW3 farhanW3 merged commit 1eb80c1 into main May 14, 2024
4 checks passed
@farhanW3 farhanW3 deleted the fk/update-error-message branch May 14, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants