Skip to content

chore: Return 4xx if invalid contract or chain in API call #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2024
Merged

chore: Return 4xx if invalid contract or chain in API call #527

merged 2 commits into from
May 15, 2024

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented May 15, 2024 •
edited by pr-codex bot
Loading

Don't return 5xx if an API call is made with an invalid contract or chain

PR-Codex overview

This PR improves error handling and caching in backend-wallet transfer and chain resolution.

Detailed summary

  • Updated comparison from lt to lte in balance check
  • Improved error handling in getContract with custom error creation
  • Enhanced chain resolution with error handling and deprecation check

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

farhanW3
farhanW3 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@farhanW3 farhanW3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arcoraven arcoraven merged commit 1dbbfb1 into main May 15, 2024
3 checks passed
@arcoraven arcoraven deleted the ph/4xxIfInvalidContractOrChain branch May 15, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhanW3 farhanW3 farhanW3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcoraven @farhanW3