Skip to content

Handling Edge Cases for RPC inconsistencies #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2024
Merged

Conversation

farhanW3
Copy link
Contributor

@farhanW3 farhanW3 commented May 15, 2024

PR-Codex overview

This PR introduces configuration changes related to contract subscriptions, including requery delays.

Detailed summary

  • Added contractSubscriptionConfigurationSchema in sharedApiSchemas.ts
  • Updated Config interface in config.ts to include contractSubscriptionsRequeryDelaySeconds
  • Modified worker tasks in chainIndexer.ts and queues in processEventLogsQueue.ts and processTransactionReceiptsQueue.ts to use contractSubscriptionsRequeryDelaySeconds
  • Updated cache retrieval in getConfig.ts to use Config interface
  • Updated response schema in routes for contract subscriptions configuration in get.ts and update.ts

The following files were skipped due to too many changes: src/server/routes/configuration/contract-subscriptions/update.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

service: "worker",
level: "warn",
message: `Block data not available: ${toBlock} on chain: ${chainId}, url: ${
(provider as StaticJsonRpcBatchProvider).connection.url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're finding ourselves doing this a few times now. Should prob just have a helper func getProviderUrl(provider)

Copy link
Contributor

@arcoraven arcoraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonblocking feedback

@farhanW3 farhanW3 merged commit 67e0908 into main May 16, 2024
4 checks passed
@farhanW3 farhanW3 deleted the fk/cs-edge-cases-upds branch May 16, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants