Skip to content

chore: fix some typos in comment (author: @toofooboo) #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/routes/backend-wallet/import.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export const importBackendWallet = async (fastify: FastifyInstance) => {
}

// TODO: with next breaking change, only require GCP KMS resource path
// import endoint does not currently have resource path in the request body
// import endpoint does not currently have resource path in the request body
// so we rely on the global configuration for these values
if (
!(
Expand Down
10 changes: 5 additions & 5 deletions src/shared/db/wallets/create-wallet-details.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type CreateWalletDetailsParams = {
}
| {
type: "aws-kms";
awsKmsKeyId?: string; // depcrecated and unused, todo: remove with next breaking change
awsKmsKeyId?: string; // deprecated and unused, todo: remove with next breaking change
awsKmsArn: string;

awsKmsSecretAccessKey: string; // will be encrypted and stored, pass plaintext to this function
Expand All @@ -24,10 +24,10 @@ type CreateWalletDetailsParams = {
| {
type: "gcp-kms";
gcpKmsResourcePath: string;
gcpKmsKeyRingId?: string; // depcrecated and unused, todo: remove with next breaking change
gcpKmsKeyId?: string; // depcrecated and unused, todo: remove with next breaking change
gcpKmsKeyVersionId?: string; // depcrecated and unused, todo: remove with next breaking change
gcpKmsLocationId?: string; // depcrecated and unused, todo: remove with next breaking change
gcpKmsKeyRingId?: string; // deprecated and unused, todo: remove with next breaking change
gcpKmsKeyId?: string; // deprecated and unused, todo: remove with next breaking change
gcpKmsKeyVersionId?: string; // deprecated and unused, todo: remove with next breaking change
gcpKmsLocationId?: string; // deprecated and unused, todo: remove with next breaking change

gcpApplicationCredentialPrivateKey: string; // will be encrypted and stored, pass plaintext to this function
gcpApplicationCredentialEmail: string;
Expand Down
2 changes: 1 addition & 1 deletion src/shared/utils/transaction/queue-transation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export type QueuedTransactionParams = {
* Encodes a transaction to generate data, and inserts it into the transaction queue using the insertTransaction()
*
* Note:
* - functionName must be be provided to populate the functionName field in the queued transaction
* - functionName must be provided to populate the functionName field in the queued transaction
* - value and chain details are resolved from the transaction
*/
export async function queueTransaction(args: QueuedTransactionParams) {
Expand Down
2 changes: 1 addition & 1 deletion src/worker/queues/send-transaction-queue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class SendTransactionQueue {
},
});

// Allow enqueing the same queueId for multiple retries.
// Allow enqueuing the same queueId for multiple retries.
static jobId = (data: SendTransactionData) =>
`${data.queueId}.${data.resendCount}`;

Expand Down
Loading