Skip to content

replace spread with individual assignment #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Apr 1, 2025

queuedTransaction has a "from" field which is the EOA address in the case of userops. The presence of a incorrect "from" address in a userop causes issues like estimation failures. To avoid this, we are selectively passing only the "data" and "value" fields, along with gas overrides.


PR-Codex overview

This PR focuses on modifying the transaction object structure in the _sendTransaction function to improve clarity and ensure that the data and value fields from queuedTransaction are explicitly included.

Detailed summary

  • Replaced the spread operator for queuedTransaction with explicit fields: data and value.
  • Updated the log message to format populatedTransaction on a new line for better readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

queuedTransaction has a "from" field which is the EOA address in the case of userops. The presence of a incorrect "from" address in a userop causes issues like estimation failures. To avoid this, we are selectively passing only the "data" and "value" fields, along with gas overrides.
Copy link

zeet-co bot commented Apr 1, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://engine-cloud-core-dev-2at8-pb-fix-60744b.chainsaw-dev.zeet.app before merging 😉

Copy link

zeet-co bot commented Apr 1, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-pb-fix-5280c7.engine-aws-usw2.zeet.app before merging 😉

@d4mr d4mr requested a review from joaquim-verges April 1, 2025 21:12
@d4mr d4mr merged commit d33fe74 into main Apr 1, 2025
7 checks passed
@d4mr d4mr deleted the pb/fix-userop-value branch April 1, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants