replace spread with individual assignment #872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queuedTransaction has a "from" field which is the EOA address in the case of userops. The presence of a incorrect "from" address in a userop causes issues like estimation failures. To avoid this, we are selectively passing only the "data" and "value" fields, along with gas overrides.
PR-Codex overview
This PR focuses on modifying the transaction object structure in the
_sendTransaction
function to improve clarity and ensure that thedata
andvalue
fields fromqueuedTransaction
are explicitly included.Detailed summary
queuedTransaction
with explicit fields:data
andvalue
.populatedTransaction
on a new line for better readability.