Skip to content

fix log parsing for internal events #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix log parsing for internal events #880

merged 1 commit into from
Apr 22, 2025

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Apr 22, 2025

PR-Codex overview

This PR enhances the getTransactionLogs function by modifying how contract addresses are handled and event signatures are resolved. It collects all relevant contract addresses from the transaction receipt and retrieves event signatures from each contract asynchronously.

Detailed summary

  • Replaced single contract variable with a Set called contracts to store unique contract addresses.
  • Added a loop to include addresses from transactionReceipt.logs.
  • Changed event signature retrieval to handle multiple contracts asynchronously.
  • Combined event signatures from all contracts into a single array.
  • Updated the mapping of event signatures to use combinedEventSignatures.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

zeet-co bot commented Apr 22, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-pb-fix-2caea8.engine-aws-usw2.zeet.app before merging 😉

@d4mr d4mr requested a review from joaquim-verges April 22, 2025 22:06
@d4mr d4mr merged commit c9695b3 into main Apr 22, 2025
5 of 6 checks passed
@d4mr d4mr deleted the pb/fix-log-parsing branch April 22, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants