fix: remove unneeded listeners that cleared caches #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're building your pull request over on Zeet. |
arcoraven
commented
Apr 24, 2025
| import { accessTokenCache } from "./access-token"; | ||
| import { invalidateConfig } from "./get-config"; | ||
| import { sdkCache } from "./get-sdk"; | ||
| import { walletsCache } from "./get-wallet"; | ||
| import { webhookCache } from "./get-webhook"; | ||
| import { keypairCache } from "./keypair"; | ||
|
|
||
| export const clearCache = async ( | ||
| _service: (typeof env)["LOG_SERVICES"][0], |
0xFirekeeper
approved these changes
Apr 24, 2025
jnsdls
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes two unneeded listeners. These caches are already cleared by the endpoints that update the data models.
PR-Codex overview
This PR primarily focuses on removing unused listeners and simplifying cache clearing functionality across various components of the application.
Detailed summary
config-listener.ts,webhook-listener.ts, andupdate-tx-listener.ts.clearCachefunction by removing the_serviceparameter.clearCacheCronto remove the_serviceparameter and adjusted its usage in the cron job.worker/index.tsandserver/index.ts.