feat: add avg, max, min to allowed functions #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe update expands the set of recognized allowed function names in the query validation logic by adding "countDistinct" along with "avg", "max", and "min" to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant QueryValidator
User->>QueryValidator: Submit query with function (e.g., "countDistinct", "avg", "max", "min")
QueryValidator->>QueryValidator: Check if function is in allowedFunctions
alt Function is allowed
QueryValidator-->>User: Accept query
else Function not allowed
QueryValidator-->>User: Reject query
end
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
internal/common/utils.go (1)
28-30: Correctly included “avg”, “max”, and “min” in allowedFunctions.The new aggregation functions match the PR objectives and integrate cleanly with the existing validation logic.
Ensure that:
- Unit tests for
ValidateQueryare updated to cover these three functions.- Any documentation or code comments listing supported functions are updated accordingly.
- (Optional) For maintainability, consider alphabetically ordering or logically grouping entries in
allowedFunctions.Would you like me to generate the corresponding test cases and update documentation?
jakeloo
approved these changes
May 23, 2025
catalyst17
force-pushed
the
feat_add_avg_max_min_to_allowed_functions
branch
from
2cc8acf to
bf71230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for
avg,max, andminfunctions to the allowed functions map.What changed?
Added three new entries to the
allowedFunctionsmap ininternal/common/utils.go:avg: for calculating averagesmax: for finding maximum valuesmin: for finding minimum valuesThese functions join the existing allowed functions like
sum,count,reinterpretasuint256,reverse, andunhex.How to test?
avg,max, andminnow execute successfullyWhy make this change?
These statistical functions are commonly needed for data analysis and aggregation operations. Adding them to the allowed functions map enables users to perform more sophisticated data processing without requiring custom implementations.
Summary by CodeRabbit