Skip to content

Commit 35279f8

Browse files
committed
[SDK] Fix: Remove co.lobstr (not EVM compatible) (#5869)
<!-- start pr-codex --> ## PR-Codex overview This PR primarily focuses on updating the wallet configurations in the `thirdweb` SDK. It removes unsupported wallets, updates wallet details, and adds new wallet entries with accurate metadata. ### Detailed summary - Removed `co.lobstr` wallet due to non-EVM compatibility. - Updated `image_id` and `homepage` for several wallets including `Coinomi`, `MetaMask`, and `Ledger Live`. - Added new wallet entries: `BeraSig`, `PortaWallet`, `Family`, `SheFi`, and others. - Updated deep link and mobile configurations for various wallets. - Changed `rdns` values for specific wallets to reflect new identifiers. > The following files were skipped due to too many changes: `packages/thirdweb/src/wallets/__generated__/wallet/io.universaleverything/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet-ids.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.huddln/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/global.safe/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/pro.tokenpocket/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.noone/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bitnovo/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.berasig/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.safepal/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/network.over/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/finance.porta/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.roninchain.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/me.rainbow/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/inc.tomo/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.trustwallet.app/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.kraken/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.safecryptowallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.walletconnect.com/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/eu.flashsoft.clear-wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.talisman/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.metamask/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/id.competence/image.ts`, `packages/thirdweb/src/react/web/ui/prebuilt/Wallet/icon.test.tsx`, `packages/thirdweb/src/wallets/__generated__/wallet/com.crypto.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.binance/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.leapwallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet-infos.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/im.token/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/app.keplr/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/org.uniswap/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bybit/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/network.mrhb/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.internetmoney/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bitget.web3/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.1inch.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.bonuz/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/ag.jup/image.ts`, `packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.moonstake/image.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
1 parent c948e71 commit 35279f8

File tree

112 files changed

+1249
-228
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

112 files changed

+1249
-228
lines changed

.changeset/pink-gorillas-try.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"thirdweb": patch
3+
---
4+
5+
SDK: Removed co.lobstr from the available wallets (an unsupported non-EVM wallet)

packages/thirdweb/scripts/wallets/generate.ts

Lines changed: 23 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ import { join } from "node:path";
44
import { format } from "prettier";
55
import sharp from "sharp";
66

7+
const EXCLUDED_WALLETS = [
8+
"co.lobstr", // Not EVM compatible
9+
];
10+
711
const walletConnectWallets = await fetch(
812
"https://explorer-api.walletconnect.com/w3m/v1/getAllListings?projectId=145769e410f16970a79ff77b2d89a1e0",
913
).then(async (res) => {
@@ -96,24 +100,26 @@ function rdns(wallet: Wallet) {
96100
.join(".");
97101
}
98102

99-
const allWalletsWithIds = allWalletsArray.map((wallet) => {
100-
// biome-ignore lint/performance/noDelete: aware it's bad but it's OK in generate script
101-
// biome-ignore lint/suspicious/noExplicitAny: aware it's bad but it's OK in generate script
102-
delete (wallet as any).order;
103-
// biome-ignore lint/performance/noDelete: aware it's bad but it's OK in generate script
104-
// biome-ignore lint/suspicious/noExplicitAny: aware it's bad but it's OK in generate script
105-
delete (wallet as any).injected;
106-
107-
const id = rdns(wallet);
108-
109-
if (id && id in deepLinkSupportedWalletsRecord) {
110-
wallet.deepLink = {
111-
mobile: deepLinkSupportedWalletsRecord[id].mobile,
112-
};
113-
}
103+
const allWalletsWithIds = allWalletsArray
104+
.map((wallet) => {
105+
// biome-ignore lint/performance/noDelete: aware it's bad but it's OK in generate script
106+
// biome-ignore lint/suspicious/noExplicitAny: aware it's bad but it's OK in generate script
107+
delete (wallet as any).order;
108+
// biome-ignore lint/performance/noDelete: aware it's bad but it's OK in generate script
109+
// biome-ignore lint/suspicious/noExplicitAny: aware it's bad but it's OK in generate script
110+
delete (wallet as any).injected;
111+
112+
const id = rdns(wallet);
113+
114+
if (id && id in deepLinkSupportedWalletsRecord) {
115+
wallet.deepLink = {
116+
mobile: deepLinkSupportedWalletsRecord[id].mobile,
117+
};
118+
}
114119

115-
return { ...wallet, id: id };
116-
});
120+
return { ...wallet, id: id };
121+
})
122+
.filter((w) => !EXCLUDED_WALLETS.includes(w.id));
117123

118124
// filter duplicate ids, we'll keep the first ones
119125

packages/thirdweb/src/react/web/ui/prebuilt/Wallet/icon.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import { WalletProvider } from "./provider.js";
55

66
describe("WalletIcon", () => {
77
it("should fetch wallet image", async () => {
8-
expect(await fetchWalletImage({ id: "io.metamask" })).toBe(
9-
"data:image/webp;base64,UklGRsgFAABXRUJQVlA4ILwFAAAwHgCdASqAAIAAPm0ylEWkIyIXTGzMQAbEoAzQSPDffG8qhx7LpfeDUfnDee/tP6gP2u9Yf0a/7L0/+pc3nivc0JlTXBvMVYW1Wt7JbdRJ1a5UhpH9+sdhAvGug20WzG+wRD+P/7/raQ1NqZ5EfcOwosQsP7NRVflPNArBLCbFJWE3EvTLNOmMfR2f+r+E2y6y1lWanc3n9RtF4lYbcW38t3UG/W2jXng4loXFOy3Vjm/r/1KHwXlpAuhAIzK/XF+ChayRFhBD+lbRrgQ3CSVjdmXw6agYPoMQ+tpjPUN/3qdGcvnN1sKWt57OGozQVSjMu0aA58MPKVWiAP77l9VfptKhZ7in3+r1DqZZQEYqO1p+MENah/WS/QQDvPuew8P0OXfahcjbCg7h4QEEEjDyfoFUbQHdw+meAsydryxVs/Ij+eB619Uj/sMgtwIifIyTieCT/hdsDmpLqGD+vOIArZfzSkordRkngojxVgvWRht84IaCHCs5Dn208UHFmyQE4KCxHef1iLYeAEPxnIAovGHIl7rCjiYE12obAM3ZCnt+RFqcT3q2rorCswc4/8f8TOhCSo63/dszpMkNQonGwtyhAFnm1EKqLPDcy99ggKQL95VYePoHcv8sHOG5zJ7lircX7VPpxkloNVWnlp/drJjQrp0h5BsOnqYn756+wcFw5qapAOnYCKUHujsoSz2BlLs1702rFpvi1iVczo2aO9GN1TaM3zBqMX0NN0YEU8pz/3+xwkK5M5q+Qb4FNJeugjdOp2kcYoOCbyAg/0OyGswYHPwDN/opVaDHWj0FcKzLq43uEjUZMG8t7O6BkoK0FmpYOeTQrinuF5F6W6ENly78daVmGPYTU22R9No5+xr8F2ESYTaJzOR3UoouY15xHrsxhDCukfebOiHljS6jUjF0TWaIAb58k57DZ3gdjkpxnJDyEmCsCOlASNWMn1ay3G8PDriQOdwsL7bgx/jZXN6XZHVx2hst/6Qcljnnn4um8eD1NcP1rTV7HMZzAb/d7ntki9zU1IFl695zPs3YT+h0PS4JuQYLzYoxpmMUQ35sVx/3KkL4Pm/TlvuNpnopM0+l2b/0OS6+5GwJYEMpzM4peYZS3qZkz/kxWNPTLv3UcCguDqpGxZ39l/VQJhSImKPZBa1RWCtSj29VCzCEZlX/eAdAKgZwhMKR4C5osznEbxjfRdHHPxjZwstCwugFa5w/WykOTFGAzk0sLSuvxO9kw/f++0WvG5La11GQaqbDDJ/ks7bcELqEGtvLHiJgxOXW9PqCk5Ap9EYelPTmdhHZgzWxtz4idN+JX+DGyYtJYjtW+Ay4kJ4Hol+Iavfje1f/22S69z1XSZ8OOcrDHKQdO1JlGaTkKQmCg5Tr05Qy9NQSfh67Vpui6OyMu38BnbG+cfWPRx/MjGQITY8w8sb1GUGd5hD9eVqycVtz8yFlYrXYQSBkAxMYgkBaiWe6kk24SoOCgt74nNs3pyTWUERw9ENESB6PyO9HjcsUZWIh97RKlf6thPtqxdlfr9i3McON9zvI7M2TtYcneXhOnqN8V4wqqII2J3DQ6/DZFNj5eNkCp2ijt7UWuKduhEmbZlLahfxD8eqBHAZR/H5rulzc4oVlyXr6qPXf9LCEuDRSDE8VNFY4NuTcaRTZO33RrWmWzbXAwpEKeH/Xf78XMoeynLBSyB+pS6y8Fqh7ExdmnvtW2gW3pwNrLc5lXlZJW8VcBzaSpy1Dmqj6Xll9BS8RyWqNx0O3fY8NJpf1exbNYMWA8juddzn2d9lHypEbiym0ASxI/jgGkbis5fecZ60QtJusJgdC8HAJEh64A9EuOCAnnISc5CElwpsvJTdEZhYv3t7MtLDvHp20lAtylt5l9yxqfCy/sqC6qZ/8+tsTAHzziGF6NKoaD0FVhZ2CER5AonJdBz5sg0rcD7arFe96uzujFDCQAAAA",
8+
expect(await fetchWalletImage({ id: "io.metamask" })).toMatchInlineSnapshot(
9+
`"data:image/webp;base64,UklGRuwGAABXRUJQVlA4IOAGAABwIQCdASqAAIAAPm0ylkekIqIhJRM72IANiWIAyqy1Dp/H+eFYv8NxdNKeeg+36Lvzn/wN975hf2w9Y/0Z/6z0a+pI9AD9Vetr8ry8NP1WRg8G/sPM3wJlt8FdNg0WVXrKZlHf/7BcL9ZlCeVp+JF3E1CbwOreB/90YH2PUR9BNzlivRmwiI5jOr6WJ/6RWb6/tZp9UbMeCRrLy+9YP/9AVZ2SFUruL/yoPkhhgYPVhVAyyvDGz6Mws+v8VQ/EqyPSTb1iD4FsNruUD7fVhplslH9Dh2EW3xy9tEeSAgV+QvEpsOf2HAqlW6VT1f2x+lkeGRKeohCDPYvoIBFLKwb4SzsF5l02NiyGaPN5/ODNR9n2EQAA/vsmBY+Q2dsG6yhgBhrmNE7GEK9pn+TE53EQ0+z+NL8/FkVgnO6FJpMGUcFQB9eOfECvyN9rfQD1Wq9X7u4/Bo7ur3bAkxWHl7CY5PlokCXuX4KvTRxdvUS23oUE2yqTSig0oRbBXdOGBXxgy6lUtFznnz+6QWb0rBEPhRqb3zKbmSL0gT4bPNaZew3h07g88/udLRjKmf0ellIolDALYrkbcJ08Y5rQ6E0xGiBrZykNg/xwYdd26p2ipY/vyeAOmddHVnBEbQglFALFMWiqCfov6s3IHwJHyP8s/h/am/pvn1gCbhTrbKI0rIuJXN2sljBDesRrvc9wpJ65o9AligVcUt3mTIDAqYysfF2QJwm3GxApi5svDwSajevWXF4z4IWOhVNDdQNKpl0+R0HUoK5n1cpWHRDrx31Hfh1SY5l/hqMOstkei+rznVXW+Ffl16KssbyiUCXQOwW4F6N00fiShJety//jfyqXXJNiY4n1xf77cqf1Z3Kq/Dnj5DKbwQ2XczShuDEsphJyn6FjFSP1e70n7d6aNp13xF9IfSa08mHGlS/jAguPwUJKwm4tly2eq+sBYDbDEkLHFKA75Y4cMSqK6+9OfNllq385/NTeOdCOGGrXAaoytxd2m1VE5dEh9lExaPxwfWhxTRD8ByR5GWe/3WMXlm6+oArrYTPKYAANBM4wAY7MPqaQzcV9rqtD+m0u22u4rdNKn1NMgoAWrlILvjQ3qqt27p32L2wf546/nQuDwGrFg+npvAMTX52Xl0SlpACvq8NqcdCKe/EWl5PfcBnKnO6JuQIEXlNWf6VLiv0VqKdwLAd96LPbBnZgbX5uX5p3GEb18QUcOFu9kMWg67HjQvmefds+kBxGh3rO/W/jFB/q67+kEKrutCcknGtEECtPBN5TIsVdn4dS/IH3DYC4HsgD09hGplPhFL99N/MXiZYbXFPYfl9H1ybPma4yljEjieZZdcHU+rncZxDm5ZgWuSTvgrgWuwzf6pHdQQVrFxhG+5PVW/IThXF50K1/g/xrcQHXOF8WvZ2Zxg9oQSPR0ArfJ8dAungVGomI9E3EIvGw9VdfiyUR0pCe+4q40mLqMoRdRplXACBrvUk1HTbqlsNYN0ElDxBW3q9Is/YDcJRWOJ3JtSxfN4yr7KY2vmgiJq04ta+fv8jDzXq35feu2ur2lYrfzHd02NaJo7W2pUyvoxCLpSM1cxr1E40s3u2ONRfn+r0r1/BpZJe0bgTwEb4I02KQak7Pl4yS1ZHwOn36HVfTrVpSc9zgG1yNOPQ4kCB6GSIZVxArMdQPKstj20YXj/i0Ra3SO7fx/14WvSIIIyNYsXbJXg8PL8fQfv9QjORNqjukfZbgusqnM8geR0pQhDfeZR1ZwdUQfx9a4Z0/fBR2Rg5zq05CcnuygEL6SZsWFBHSOeaUT3ycQQp2rHbHlnYT/GOaoUYR5wtGBahqXy0xBlaisNqZa6GEoHxzNKiMt2sGrcS079jZa5kDaGtSrW41e1HoLpuxwxiUKntwnjEaogJri9FgAxC6wazG6U56P6C/zJWsilWgi6jCsfORkpXQM91vYMgRL3+HiFzD93LPP13w/x8Hhty4jtCowlCzf0MqrScu+oDOCoMbdXV9j0OCfAZYXHdf9R1hgLmFjBk0kOl8O8HZucC6eUve6XVrJ/92ne39q3XC8uJ86jEyTYpzJOSzAbLiP8jSgLetO3pxmTa43aS527rhvZ8JL5yAffh+31QM7yH5z7OCSLeVOGJlwXqhF7scYXy5kaJdg93oEYrUhpHMTh3KV9Ex0Qf4/M7ucWrOpBR6AjyIGlvU92DbSj/ggL5w4N4wHUCOflgeum/BI6G33QdKXXJiebFiJIjyiYk4NPu4R2LxJkK7hMBIka6NtNFZCkGHgF/Dlwx36B0nZFYvHt1ciHu2IKWOpl9AdQeQo0jWiBOpElR7LhlhAHUTnP2S2VxoQCAAAA=="`,
1010
);
1111
});
1212

0 commit comments

Comments
 (0)