Merge branch 'main' into greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed

Author: gregfromstl

.changeset/fair-planes-doubt.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+SDK: Fix chain switching in smart account transactions

.changeset/little-beds-dress.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Add onTimeout callback to useAutoConnect

.changeset/pink-gorillas-try.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+SDK: Removed co.lobstr from the available wallets (an unsupported non-EVM wallet)

.changeset/yellow-experts-sparkle.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+SDK: Gracefully ignore chain with no chain ID in `fromEip1193Provider`

.github/pull_request_template.md

@@ -1,4 +1,12 @@
-## Problem solved
+---
+title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
+---
 
-Short description of the bug fixed or feature added
+If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
+
+## Notes for the reviewer
+Anything important to call out? Be sure to also clarify these in your comments.
+
+## How to test
+Unit tests, playground, etc.
 

.github/workflows/auto-assign.yml

@@ -13,6 +13,7 @@ jobs:
     if: |
       github.event.pull_request.author_association == 'MEMBER' ||
       github.event.pull_request.author_association == 'OWNER' ||
-      github.event.pull_request.author_association == 'COLLABORATOR'
+      github.event.pull_request.author_association == 'COLLABORATOR' ||
+      github.event.pull_request.author_association == 'CONTRIBUTOR'
     steps:
       - uses: toshimaru/auto-author-assign@v2.1.1

.github/workflows/issue.yml

@@ -5,7 +5,7 @@ on:
     types: [opened, edited, ready_for_review]
 
 env:
-  VALID_ISSUE_PREFIXES: "CORE|TOOL"
+  VALID_ISSUE_PREFIXES: "CORE|TOOL|NEB|INFRA"
 
 jobs:
   linear:

.github/workflows/stale.yml

@@ -9,7 +9,7 @@ jobs:
     steps:
       - uses: actions/stale@v9
         with:
-          stale-issue-message: 'This issue has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs.'
-          stale-pr-message: 'This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs.'
+          stale-issue-message: 'This issue has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.'
+          stale-pr-message: 'This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.'
           days-before-stale: 7
           days-before-close: 2

apps/dashboard/next-env.d.ts

@@ -3,4 +3,4 @@
 /// <reference types="next/navigation-types/compat/navigation" />
 
 // NOTE: This file should not be edited
-// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
+// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.

apps/dashboard/package.json

@@ -68,7 +68,7 @@
     "ioredis": "^5.4.1",
     "ipaddr.js": "^2.2.0",
     "lucide-react": "0.468.0",
-    "next": "15.1.0",
+    "next": "15.1.3",
     "next-plausible": "^3.12.4",
     "next-seo": "^6.5.0",
     "next-themes": "^0.4.4",
@@ -85,7 +85,7 @@
     "react-dom": "19.0.0",
     "react-dropzone": "^14.3.5",
     "react-error-boundary": "^4.1.2",
-    "react-hook-form": "7.53.2",
+    "react-hook-form": "7.54.2",
     "react-markdown": "^9.0.1",
     "react-table": "^7.8.0",
     "recharts": "2.14.1",

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/components/list-form.tsx

@@ -18,6 +18,7 @@ import { CurrencySelector } from "components/shared/CurrencySelector";
 import { SolidityInput } from "contract-ui/components/solidity-inputs";
 import { useTrack } from "hooks/analytics/useTrack";
 import { useAllChainsData } from "hooks/chains/allChains";
+import { useTxNotifications } from "hooks/useTxNotifications";
 import { isAlchemySupported } from "lib/wallet/nfts/alchemy";
 import { isMoralisSupported } from "lib/wallet/nfts/moralis";
 import { isSimpleHashSupported } from "lib/wallet/nfts/simpleHash";
@@ -125,6 +126,15 @@ export const CreateListingsForm: React.FC<CreateListingsFormProps> = ({
     walletAddress: account?.address,
   });
   const sendAndConfirmTx = useSendAndConfirmTransaction();
+  const listingNotifications = useTxNotifications(
+    "NFT listed Successfully",
+    "Failed to list NFT",
+  );
+
+  const auctionNotifications = useTxNotifications(
+    "Auction created successfully",
+    "Failed to create an auction",
+  );
 
   const form = useForm<ListForm>({
     defaultValues:
@@ -351,14 +361,11 @@ export const CreateListingsForm: React.FC<CreateListingsFormProps> = ({
               endTimestamp,
             });
 
-            const promise = sendAndConfirmTx.mutateAsync(transaction, {
+            await sendAndConfirmTx.mutateAsync(transaction, {
               onSuccess: () => setOpen(false),
             });
-            toast.promise(promise, {
-              loading: "Listing NFT",
-              success: "NFT listed successfully",
-              error: "Failed to list NFT",
-            });
+
+            listingNotifications.onSuccess();
           } else if (formData.listingType === "auction") {
             let minimumBidAmountWei: bigint;
             let buyoutBidAmountWei: bigint;
@@ -403,7 +410,7 @@ export const CreateListingsForm: React.FC<CreateListingsFormProps> = ({
               buyoutBidAmountWei: buyoutBidAmountWei * selectedQuantity,
             });
 
-            const promise = sendAndConfirmTx.mutateAsync(transaction, {
+            await sendAndConfirmTx.mutateAsync(transaction, {
               onSuccess: () => {
                 trackEvent({
                   category: "marketplace",
@@ -423,15 +430,15 @@ export const CreateListingsForm: React.FC<CreateListingsFormProps> = ({
                 });
               },
             });
-            toast.promise(promise, {
-              loading: "Creating auction",
-              success: "Auction created successfully",
-              error: "Failed to create auction",
-            });
+            auctionNotifications.onSuccess();
           }
         } catch (err) {
           console.error(err);
-          toast.error("Failed to list NFT");
+          if (formData.listingType === "auction") {
+            auctionNotifications.onError(err);
+          } else {
+            listingNotifications.onError(err);
+          }
         }
 
         setIsFormLoading(false);

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/components/airdrop-tab.tsx

@@ -12,6 +12,7 @@ import { cn } from "@/lib/utils";
 import type { Account } from "@3rdweb-sdk/react/hooks/useApi";
 import { TransactionButton } from "components/buttons/TransactionButton";
 import { useTrack } from "hooks/analytics/useTrack";
+import { useTxNotifications } from "hooks/useTxNotifications";
 import { UploadIcon } from "lucide-react";
 import { useState } from "react";
 import { useForm } from "react-hook-form";
@@ -49,6 +50,10 @@ const AirdropTab: React.FC<AirdropTabProps> = ({
   const sendAndConfirmTx = useSendAndConfirmTransaction();
   const addresses = watch("addresses");
   const [open, setOpen] = useState(false);
+  const airdropNotifications = useTxNotifications(
+    "NFTs airdropped successfully",
+    "Failed to airdrop NFTs",
+  );
 
   return (
     <div className="flex w-full flex-col gap-2">
@@ -86,7 +91,7 @@ const AirdropTab: React.FC<AirdropTabProps> = ({
               }),
             );
             const transaction = multicall({ contract, data });
-            const promise = sendAndConfirmTx.mutateAsync(transaction, {
+            await sendAndConfirmTx.mutateAsync(transaction, {
               onSuccess: () => {
                 trackEvent({
                   category: "nft",
@@ -108,14 +113,11 @@ const AirdropTab: React.FC<AirdropTabProps> = ({
                 });
               },
             });
-            toast.promise(promise, {
-              loading: "Airdropping NFTs",
-              success: "Airdropped successfully",
-              error: "Failed to airdrop",
-            });
+
+            airdropNotifications.onSuccess();
           } catch (err) {
             console.error(err);
-            toast.error("Failed to airdrop NFTs");
+            airdropNotifications.onError(err);
           }
         })}
       >

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/components/update-metadata-form.tsx

@@ -18,6 +18,7 @@ import { PropertiesFormControl } from "components/contract-pages/forms/propertie
 import { FileInput } from "components/shared/FileInput";
 import { useTrack } from "hooks/analytics/useTrack";
 import { useImageFileOrUrl } from "hooks/useImageFileOrUrl";
+import { useTxNotifications } from "hooks/useTxNotifications";
 import { type Dispatch, type SetStateAction, useMemo } from "react";
 import { useForm } from "react-hook-form";
 import { toast } from "sonner";
@@ -166,12 +167,16 @@ export const UpdateNftMetadata: React.FC<UpdateNftMetadataForm> = ({
     watch("animation_url") instanceof File ||
     watch("external_url") instanceof File;
   const sendAndConfirmTx = useSendAndConfirmTransaction();
+  const updateMetadataNotifications = useTxNotifications(
+    "NFT metadata updated successfully",
+    "Failed to update NFT metadata",
+  );
 
   return (
     <form
       className="flex flex-col gap-6"
       id={UPDATE_METADATA_FORM_ID}
-      onSubmit={handleSubmit((data) => {
+      onSubmit={handleSubmit(async (data) => {
         if (!address) {
           toast.error("Please connect your wallet to update metadata.");
           return;
@@ -217,7 +222,7 @@ export const UpdateNftMetadata: React.FC<UpdateNftMetadataForm> = ({
                   tokenId: BigInt(nft.id),
                   newMetadata,
                 });
-          const promise = sendAndConfirmTx.mutateAsync(transaction, {
+          await sendAndConfirmTx.mutateAsync(transaction, {
             onSuccess: () => {
               trackEvent({
                 category: "nft",
@@ -237,13 +242,10 @@ export const UpdateNftMetadata: React.FC<UpdateNftMetadataForm> = ({
             },
           });
 
-          toast.promise(promise, {
-            error: "Failed to update NFT metadata",
-            success: "NFT metadata updated successfully",
-          });
+          updateMetadataNotifications.onSuccess();
         } catch (err) {
           console.error(err);
-          toast.error("Failed to update NFT metadata");
+          updateMetadataNotifications.onError(err);
         }
       })}
     >

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/claim-button.tsx

@@ -12,11 +12,12 @@ import type { Account } from "@3rdweb-sdk/react/hooks/useApi";
 import { FormControl, Input } from "@chakra-ui/react";
 import { TransactionButton } from "components/buttons/TransactionButton";
 import { useTrack } from "hooks/analytics/useTrack";
+import { useTxNotifications } from "hooks/useTxNotifications";
 import { GemIcon } from "lucide-react";
 import { useState } from "react";
 import { useForm } from "react-hook-form";
 import { toast } from "sonner";
-import { type ThirdwebContract, ZERO_ADDRESS } from "thirdweb";
+import { type ThirdwebContract, ZERO_ADDRESS, isAddress } from "thirdweb";
 import { getApprovalForTransaction } from "thirdweb/extensions/erc20";
 import { claimTo } from "thirdweb/extensions/erc721";
 import { useActiveAccount, useSendAndConfirmTransaction } from "thirdweb/react";
@@ -39,13 +40,17 @@ export const NFTClaimButton: React.FC<NFTClaimButtonProps> = ({
 }) => {
   const trackEvent = useTrack();
   const address = useActiveAccount()?.address;
-  const { register, handleSubmit, formState } = useForm({
+  const { register, handleSubmit, formState, setValue } = useForm({
     defaultValues: { amount: "1", to: address },
   });
   const { errors } = formState;
   const sendAndConfirmTx = useSendAndConfirmTransaction();
   const account = useActiveAccount();
   const [open, setOpen] = useState(false);
+  const claimNFTNotifications = useTxNotifications(
+    "NFT claimed successfully",
+    "Failed to claim NFT",
+  );
 
   return (
     <Sheet open={open} onOpenChange={setOpen}>
@@ -62,7 +67,24 @@ export const NFTClaimButton: React.FC<NFTClaimButtonProps> = ({
           <div className="flex w-full flex-col gap-6 md:flex-row">
             <FormControl isRequired isInvalid={!!errors.to}>
               <FormLabel>To Address</FormLabel>
-              <Input placeholder={ZERO_ADDRESS} {...register("to")} />
+              <Input
+                placeholder={ZERO_ADDRESS}
+                {...register("to", {
+                  validate: (value) => {
+                    if (!value) {
+                      return "Enter a recipient address";
+                    }
+                    if (!isAddress(value.trim())) {
+                      return "Invalid EVM address";
+                    }
+                  },
+                  onChange: (e) => {
+                    setValue("to", e.target.value.trim(), {
+                      shouldValidate: true,
+                    });
+                  },
+                })}
+              />
               <FormHelperText>Enter the address to claim to.</FormHelperText>
               <FormErrorMessage>{errors.to?.message}</FormErrorMessage>
             </FormControl>
@@ -110,7 +132,7 @@ export const NFTClaimButton: React.FC<NFTClaimButtonProps> = ({
 
                 const transaction = claimTo({
                   contract,
-                  to: d.to,
+                  to: d.to.trim(),
                   quantity: BigInt(d.amount),
                   from: account.address,
                 });
@@ -135,7 +157,7 @@ export const NFTClaimButton: React.FC<NFTClaimButtonProps> = ({
                   await promise;
                 }
 
-                const promise = sendAndConfirmTx.mutateAsync(transaction, {
+                await sendAndConfirmTx.mutateAsync(transaction, {
                   onSuccess: () => {
                     trackEvent({
                       category: "nft",
@@ -154,14 +176,10 @@ export const NFTClaimButton: React.FC<NFTClaimButtonProps> = ({
                   },
                 });
 
-                toast.promise(promise, {
-                  loading: "Claiming NFT(s)",
-                  success: "NFT(s) claimed successfully",
-                  error: "Failed to claim NFT(s)",
-                });
+                claimNFTNotifications.onSuccess();
               } catch (error) {
                 console.error(error);
-                toast.error((error as Error).message || "Error claiming NFT");
+                claimNFTNotifications.onError(error);
                 trackEvent({
                   category: "nft",
                   action: "claim",