Skip to content

[SDK] Feature: Add wagmi adapter for in-app wallet #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 6, 2024

Problem solved

CNCT-2566


PR-Codex overview

This PR introduces the wagmi-adapter package, enabling integration of thirdweb's in-app wallets with wagmi. It includes new types, functions, and example usage for connecting to in-app wallets, along with configuration files for TypeScript support.

Detailed summary

  • Added README.md for wagmi-adapter with usage instructions.
  • Exported inAppWalletConnector and related types from thirdweb.ts.
  • Updated tsconfig files for build and development configurations.
  • Enhanced wallet exports in wallets.ts and wallets.native.ts.
  • Defined InAppWalletConnectionOptions using Prettify for better type handling.
  • Introduced example code snippets for connecting to in-app wallets.
  • Updated package.json for wagmi-adapter with dependencies and scripts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:48am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:48am
thirdweb-www ❌ Failed (Inspect) Dec 13, 2024 2:48am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:48am

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 391319a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/wagmi-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review December 6, 2024 03:12
Copy link
Member Author

joaquim-verges commented Dec 6, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges force-pushed the feat_Add_wagmi_adapter_for_in-app_wallet branch from fce76b8 to c61df2c Compare December 6, 2024 03:13
Copy link

socket-security bot commented Dec 6, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@wagmi/core@2.16.0 None +2 2.17 MB awkweb

View full report↗︎

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.85%. Comparing base (c91ca93) to head (391319a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5644      +/-   ##
==========================================
- Coverage   52.89%   52.85%   -0.04%     
==========================================
  Files        1098     1098              
  Lines       58976    58976              
  Branches     4792     4788       -4     
==========================================
- Hits        31193    31173      -20     
- Misses      27065    27087      +22     
+ Partials      718      716       -2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c91ca93
packages 49.95% <ø> (-0.05%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 442 ms (+45.69% 🔺) 1.4 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 882 ms (+21.18% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 266 ms (+1892.3% 🔺) 378 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 164 ms (+846.97% 🔺) 174 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 197 ms (+276.42% 🔺) 578 ms

@joaquim-verges joaquim-verges force-pushed the feat_Add_wagmi_adapter_for_in-app_wallet branch from f017a05 to 8496237 Compare December 12, 2024 23:57
@joaquim-verges joaquim-verges force-pushed the feat_Add_wagmi_adapter_for_in-app_wallet branch from 8496237 to 6052378 Compare December 13, 2024 01:35
@github-actions github-actions bot added the SDK Involves changes to the thirdweb SDK label Dec 13, 2024
@joaquim-verges joaquim-verges force-pushed the feat_Add_wagmi_adapter_for_in-app_wallet branch from 6052378 to 73b2d9b Compare December 13, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants