Skip to content

chore: Add modelName, sessionId, requestId usage #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Dec 9, 2024

https://linear.app/thirdweb/issue/DASH-574/add-nebula-usage-tracker-events


PR-Codex overview

This PR focuses on enhancing the usageEventSchema in the @thirdweb-dev/service-utils package by adding new optional fields for better tracking of usage events.

Detailed summary

  • Added modelName, sessionId, and requestId as optional fields to the usageEventSchema in packages/service-utils/src/core/usage.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 7b4f75e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:03am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:03am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:03am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:03am

Copy link
Contributor

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.71%. Comparing base (3b53732) to head (e702490).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5670   +/-   ##
=======================================
  Coverage   50.71%   50.71%           
=======================================
  Files        1092     1092           
  Lines       57209    57209           
  Branches     4629     4629           
=======================================
  Hits        29015    29015           
  Misses      27478    27478           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3b53732
packages 47.20% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 1.1 s (-6.93% 🔽) 2 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 2.4 s (-9.46% 🔽) 4.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 64 ms (-2.23% 🔽) 175 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 18 ms (-2.73% 🔽) 28 ms
thirdweb/react (minimal + tree-shaking) 19.01 KB (0%) 381 ms (0%) 250 ms (-21.32% 🔽) 631 ms

@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 10, 2024
Copy link
Contributor Author

arcoraven commented Dec 10, 2024

Merge activity

  • Dec 9, 7:17 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 9, 7:36 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 9, 8:04 PM EST: A user merged this pull request with the Graphite merge queue.

https://linear.app/thirdweb/issue/DASH-574/add-nebula-usage-tracker-events

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces additional properties to the `usageEventSchema` in the `service-utils` package, enhancing the tracking of usage events by including identifiers for the model, session, and request.

### Detailed summary
- Added `modelName`, `sessionId`, and `requestId` as optional string fields to the `usageEventSchema` in `packages/service-utils/src/core/usage.ts`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants