fix: should always contain gas price info even if it's 0 #5673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
joaquim-verges,
gregfromstl and
jnsdls
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c55f02f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
| transaction.type = 2; | ||
| } else { | ||
| transaction.gasPrice = | ||
| typeof tx.gasPrice === "bigint" ? toHex(tx.gasPrice) : undefined; | ||
| typeof tx.gasPrice === "bigint" ? toHex(tx.gasPrice) : toHex("0"); |
There was a problem hiding this comment.
this is dangerous, a lot of tools like at the presence of gasPrice to know if its a legacy tx
we cant risk sending all values, has to be one or the other
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5673 +/- ##
=======================================
Coverage 50.71% 50.71%
=======================================
Files 1092 1092
Lines 57209 57209
Branches 4629 4628 -1
=======================================
Hits 29015 29015
Misses 27478 27478
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more. |
ElasticBottle
added
the
merge-queue
Merge activity
|
joaquim-verges
approved these changes
Dec 10, 2024
https://linear.app/thirdweb/issue/CNCT-2602/issue-signing-deploy-tx-on-saakura <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on ensuring that gas price information is always included for enclave wallets, even when it is 0. It modifies the condition for setting the `maxFeePerGas` to check for the type `bigint`. ### Detailed summary - Updated the condition to check if `tx.maxFeePerGas` is of type `bigint`. - Ensured that `transaction.maxFeePerGas` is set correctly when `tx.maxFeePerGas` is provided. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/cnct-2602-issue-signing-deploy-tx-on-saakura
branch
from
7863edc to
c55f02f
Compare
graphite-app
bot
deleted the
winston/cnct-2602-issue-signing-deploy-tx-on-saakura
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/issue/CNCT-2602/issue-signing-deploy-tx-on-saakura
PR-Codex overview
This PR focuses on ensuring that gas price information is always included for enclave wallets, even when it is set to 0. It modifies the condition for checking
maxFeePerGasto ensure proper handling of gas fees.Detailed summary
maxFeePerGasto check if it is of typebigint.