Skip to content

fix: removed login navigation text #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

jakubkrehel
Copy link
Contributor

@jakubkrehel jakubkrehel commented Dec 10, 2024

Fixes: DASH-579

PR-Codex overview

This PR focuses on modifying the LoginPage component by removing a heading element to streamline the layout.

Detailed summary

  • Removed the <h1> element with the text "Get started with thirdweb" from the LoginPage component.
  • The surrounding <div> elements remain unchanged, maintaining the overall structure and styling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 969be18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 8:41pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 10, 2024 8:41pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 10, 2024 8:41pm
wallet-ui ⬜️ Skipped (Inspect) Dec 10, 2024 8:41pm

Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.23%. Comparing base (27d3a6e) to head (969be18).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5680   +/-   ##
=======================================
  Coverage   51.23%   51.23%           
=======================================
  Files        1092     1092           
  Lines       57346    57346           
  Branches     4677     4677           
=======================================
  Hits        29383    29383           
  Misses      27247    27247           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 27d3a6e
packages 47.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 3.2 s (+19.45% 🔺) 4.1 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 7.5 s (+2.43% 🔺) 9.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 440 ms (+217.23% 🔺) 552 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 54 ms (+34.12% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 19.01 KB (0%) 381 ms (0%) 561 ms (+22.34% 🔺) 941 ms

Copy link

linear bot commented Dec 10, 2024

@jnsdls jnsdls merged commit 67305d3 into main Dec 10, 2024
32 of 34 checks passed
@jnsdls jnsdls deleted the removed-navigation-login-text branch December 10, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants