-
Notifications
You must be signed in to change notification settings - Fork 542
[SDK] Fix: Pay not respecting ecosystem AA #5682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix: Pay not respecting ecosystem AA #5682
Conversation
🦋 Changeset detectedLatest commit: 5b24faf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5682 +/- ##
==========================================
+ Coverage 51.23% 51.27% +0.04%
==========================================
Files 1092 1092
Lines 57346 57346
Branches 4677 4686 +9
==========================================
+ Hits 29383 29406 +23
+ Misses 27247 27224 -23
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
|
0747ec7
to
0e79141
Compare
Merge activity
|
<!-- start pr-codex --> ## PR-Codex overview This PR focuses on enhancing the detection of ecosystem wallets in the `Pay` modal by modifying the logic in the `hasSponsoredTransactionsEnabled` function and adding comprehensive tests for various wallet configurations. ### Detailed summary - Updated the condition in `hasSponsoredTransactionsEnabled` to check for ecosystem wallets. - Added tests for `hasSponsoredTransactionsEnabled` covering: - Undefined wallet - Smart wallet with `sponsorGas` config - Smart wallet with `gasless` config - In-app wallet with `smartAccount` config - Regular wallet without smart account config > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
0e79141
to
5b24faf
Compare
PR-Codex overview
This PR focuses on improving the detection of ecosystem wallets in the
Pay
modal by modifying the logic in thehasSponsoredTransactionsEnabled
function and adding comprehensive tests for various wallet configurations.Detailed summary
hasSponsoredTransactionsEnabled
to check for ecosystem wallets usingisEcosystemWallet
.hasSponsoredTransactionsEnabled
covering:sponsorGas
andgasless
configurationssmartAccount
configurations