Skip to content

[SDK] Fix: Pay not respecting ecosystem AA #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 10, 2024

PR-Codex overview

This PR focuses on improving the detection of ecosystem wallets in the Pay modal by modifying the logic in the hasSponsoredTransactionsEnabled function and adding comprehensive tests for various wallet configurations.

Detailed summary

  • Updated the condition in hasSponsoredTransactionsEnabled to check for ecosystem wallets using isEcosystemWallet.
  • Added tests for hasSponsoredTransactionsEnabled covering:
    • Undefined wallets
    • Smart wallets with sponsorGas and gasless configurations
    • In-app wallets with smartAccount configurations
    • Regular wallets without smart account configurations

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 10, 2024

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 5b24faf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:07am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:07am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:07am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:07am

Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 277 ms (+21.07% 🔺) 1.2 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 589 ms (-27.19% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 78 ms (+462.18% 🔺) 190 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 6 ms (+8.51% 🔺) 16 ms
thirdweb/react (minimal + tree-shaking) 19.01 KB (0%) 381 ms (0%) 161 ms (+234.53% 🔺) 541 ms

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.27%. Comparing base (714602d) to head (5b24faf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5682      +/-   ##
==========================================
+ Coverage   51.23%   51.27%   +0.04%     
==========================================
  Files        1092     1092              
  Lines       57346    57346              
  Branches     4677     4686       +9     
==========================================
+ Hits        29383    29406      +23     
+ Misses      27247    27224      -23     
  Partials      716      716              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 714602d
packages 47.90% <100.00%> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/react/core/utils/wallet.ts 37.24% <100.00%> (+18.62%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on enhancing the detection of ecosystem wallets in the `Pay` modal by modifying the logic in the `hasSponsoredTransactionsEnabled` function and adding comprehensive tests for various wallet configurations.

### Detailed summary
- Updated the condition in `hasSponsoredTransactionsEnabled` to check for ecosystem wallets.
- Added tests for `hasSponsoredTransactionsEnabled` covering:
  - Undefined wallet
  - Smart wallet with `sponsorGas` config
  - Smart wallet with `gasless` config
  - In-app wallet with `smartAccount` config
  - Regular wallet without smart account config

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants