fix ignore of mimeTime set in mediaRenderer #5683

dirtycajunrice · 2024-12-10T22:17:16Z

Problem solved

PR-Codex overview

This PR modifies the return object in the useResolvedMediaType.ts file to enhance the isFetched property by including a check for mimeType.

Detailed summary

Updated the isFetched property in the returned object.
Changed the value of isFetched from resolvedMimeType.isFetched to resolvedMimeType.isFetched || !!mimeType.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-12-10T22:17:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 11, 2024 7:38am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 11, 2024 7:38am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 11, 2024 7:38am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 11, 2024 7:38am

changeset-bot · 2024-12-10T22:17:21Z

⚠️ No Changeset found

Latest commit: f6dca69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-12-10T22:17:24Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

dirtycajunrice · 2024-12-10T22:17:34Z

add roleBytes utility for contract role usage #5685
fix ignore of mimeTime set in mediaRenderer #5683 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2024-12-10T22:20:42Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	44.93 KB (0%)	899 ms (0%)	1.5 s (-25.66% 🔽)	2.4 s
thirdweb (cjs)	110.71 KB (0%)	2.3 s (0%)	4.8 s (+12.41% 🔺)	7 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	126 ms (-66.74% 🔽)	237 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	28 ms (-51.45% 🔽)	38 ms
thirdweb/react (minimal + tree-shaking)	19.07 KB (0%)	382 ms (0%)	741 ms (+142.54% 🔺)	1.2 s

codecov · 2024-12-10T22:23:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.28%. Comparing base (a9dd26c) to head (d74127f).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5683      +/-   ##
==========================================
+ Coverage   51.27%   51.28%   +0.01%     
==========================================
  Files        1092     1092              
  Lines       57346    57346              
  Branches     4685     4688       +3     
==========================================
+ Hits        29404    29410       +6     
+ Misses      27226    27220       -6     
  Partials      716      716

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from a9dd26c
packages	`47.91% <100.00%> (+0.01%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...react/web/ui/MediaRenderer/useResolvedMediaType.ts	`89.18% <100.00%> (ø)`

... and 3 files with indirect coverage changes

graphite-app · 2024-12-11T00:41:33Z

Merge activity

Dec 10, 7:41 PM EST: A user added this pull request to the Graphite merge queue.
Dec 10, 7:46 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
Dec 11, 1:59 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 11, 2:29 AM EST: A user added this pull request to the Graphite merge queue.
Dec 11, 2:33 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
Dec 11, 2:33 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 11, 7:33 AM UTC: The merge label 'merge-queue' was removed. This PR will no longer be merged by the Graphite merge queue

## Problem solved CNCT-2634  --- ## PR-Codex overview This PR modifies the `isFetched` property in the `useResolvedMediaType.ts` file to include an additional condition for its value, enhancing the logic that determines whether media type data has been successfully fetched. ### Detailed summary - The `isFetched` property is updated to: - Use `resolvedMimeType.isFetched` or check if `mimeType` is truthy (`!!mimeType`). > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

## Problem solved CNCT-2634  --- ## PR-Codex overview This PR focuses on updating the `isFetched` property in the `useResolvedMediaType.ts` file to include an additional condition based on `mimeType`. This change aims to enhance the logic determining if the media type has been successfully fetched. ### Detailed summary - Updated the `isFetched` property: - Changed from `resolvedMimeType.isFetched` to `resolvedMimeType.isFetched || !!mimeType`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

dirtycajunrice requested review from joaquim-verges, gregfromstl, MananTank, jnsdls and edwardysun as code owners December 10, 2024 22:17

github-actions bot assigned dirtycajunrice Dec 10, 2024

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 10, 2024

vercel bot deployed to Preview – wallet-ui December 10, 2024 22:20 View deployment

vercel bot deployed to Preview – thirdweb_playground December 10, 2024 22:20 View deployment

dirtycajunrice mentioned this pull request Dec 10, 2024

add roleBytes utility for contract role usage #5685

Closed

vercel bot deployed to Preview – docs-v2 December 10, 2024 22:27 View deployment

vercel bot deployed to Preview – thirdweb-www December 10, 2024 22:29 View deployment

joaquim-verges approved these changes Dec 11, 2024

View reviewed changes

joaquim-verges force-pushed the 12-10-fix_ignore_of_mimetime_set_in_mediarenderer branch from 9760615 to d74127f Compare December 11, 2024 00:42

vercel bot deployed to Preview – thirdweb_playground December 11, 2024 00:49 View deployment

vercel bot deployed to Preview – wallet-ui December 11, 2024 00:51 View deployment

vercel bot deployed to Preview – docs-v2 December 11, 2024 00:53 View deployment

vercel bot deployed to Preview – thirdweb-www December 11, 2024 00:55 View deployment

joaquim-verges added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 11, 2024

joaquim-verges force-pushed the 12-10-fix_ignore_of_mimetime_set_in_mediarenderer branch from d74127f to f6dca69 Compare December 11, 2024 07:29

vercel bot deployed to Preview – wallet-ui December 11, 2024 07:32 View deployment

vercel bot deployed to Preview – thirdweb_playground December 11, 2024 07:32 View deployment

graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Dec 11, 2024

vercel bot deployed to Preview – thirdweb-www December 11, 2024 07:38 View deployment

vercel bot deployed to Preview – docs-v2 December 11, 2024 07:38 View deployment

joaquim-verges merged commit c91ca93 into main Dec 13, 2024
28 of 29 checks passed

joaquim-verges deleted the 12-10-fix_ignore_of_mimetime_set_in_mediarenderer branch December 13, 2024 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix ignore of mimeTime set in mediaRenderer #5683

fix ignore of mimeTime set in mediaRenderer #5683

Uh oh!

dirtycajunrice commented Dec 10, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Dec 10, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 10, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 10, 2024

Uh oh!

dirtycajunrice commented Dec 10, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 10, 2024 •

edited

Loading

Uh oh!

codecov bot commented Dec 10, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 11, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix ignore of mimeTime set in mediaRenderer #5683

fix ignore of mimeTime set in mediaRenderer #5683

Uh oh!

Conversation

dirtycajunrice commented Dec 10, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

dirtycajunrice commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

dirtycajunrice commented Dec 10, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 10, 2024 •

edited

Loading

changeset-bot bot commented Dec 10, 2024 •

edited

Loading

dirtycajunrice commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading

graphite-app bot commented Dec 11, 2024 •

edited

Loading