Skip to content

Nebula scope changes in create project modal and project settings page #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 10, 2024

DASH-578


PR-Codex overview

This PR focuses on enhancing the handling of Nebula settings across various components, including the introduction of enableNebulaServiceByDefault and adjustments to team and project management functions.

Detailed summary

  • Added showNebulaSettings and enableNebulaServiceByDefault props in multiple components.
  • Updated createProject functions to accept a team parameter.
  • Refactored project and team-related pages to use team instead of team_slug.
  • Removed nebula from HIDDEN_SERVICES.
  • Enhanced ProjectGeneralSettingsPageForTeams to handle team directly.
  • Adjusted dialogs to reflect Nebula settings based on team capabilities.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:15pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 10, 2024 11:15pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 10, 2024 11:15pm
wallet-ui ⬜️ Skipped (Inspect) Dec 10, 2024 11:15pm

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 714602d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 10, 2024 22:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 10, 2024 22:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 10, 2024 22:21 Inactive
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Dec 10, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title Nebula scope relatied changes in create project modal and project settings page Nebula scope changes in create project modal and project settings page Dec 10, 2024
@MananTank MananTank marked this pull request as ready for review December 10, 2024 22:22
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.23%. Comparing base (c11ae45) to head (714602d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5684   +/-   ##
=======================================
  Coverage   51.23%   51.23%           
=======================================
  Files        1092     1092           
  Lines       57346    57346           
  Branches     4677     4677           
=======================================
  Hits        29383    29383           
  Misses      27247    27247           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c11ae45
packages 47.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 2.8 s (+4.99% 🔺) 3.7 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 7.1 s (+57.95% 🔺) 9.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 200 ms (+23.22% 🔺) 312 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 86 ms (+106.18% 🔺) 96 ms
thirdweb/react (minimal + tree-shaking) 19.01 KB (0%) 381 ms (0%) 439 ms (-8.87% 🔽) 819 ms

Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Merge activity

@jnsdls jnsdls force-pushed the 12-11-nebula_scope_relatied_changes_in_create_project_modal_and_project_settings_page branch from 427f6fa to 714602d Compare December 10, 2024 23:07
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 10, 2024 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 10, 2024 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 10, 2024 23:07 Inactive
@graphite-app graphite-app bot merged commit 714602d into main Dec 10, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-11-nebula_scope_relatied_changes_in_create_project_modal_and_project_settings_page branch December 10, 2024 23:15
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 10, 2024 23:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants