Compute addresses with ref contracts #5699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaryash90
requested review from
joaquim-verges,
gregfromstl and
jnsdls
as code owners
🦋 Changeset detectedLatest commit: 1273cc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5699 +/- ##
==========================================
+ Coverage 54.73% 54.81% +0.07%
==========================================
Files 874 875 +1
Lines 54710 54851 +141
Branches 3712 3736 +24
==========================================
+ Hits 29946 30066 +120
- Misses 24669 24690 +21
Partials 95 95
🚀 New features to boost your workflow:
|
kumaryash90
added
the
merge-queue
Merge activity
|
TOOL-2796 (XPROT-934)
## Problem solved
This was an issue when installing modules published with ref contracts. Module installation goes through infra deployment functions which use computed addresses.
SDK should process ref contracts when computing published contract addresses.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the handling of published contract references in the `thirdweb` library, particularly in the deployment process. It introduces a new function to compute addresses for these references and updates existing functions and tests accordingly.
### Detailed summary
- Added `processRefDeployments` function to process contract references in constructor params.
- Introduced `computeRefDeployments` function for computing addresses of published contract references.
- Updated the handling of `salt` values to default to an empty string instead of `"thirdweb"`.
- Modified `computeDeploymentInfoFromMetadata` to use processed constructor parameters.
- Adjusted tests to reflect changes in contract deployment parameters and added new tests for address computation of deployed contracts with references.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
yash/compute-ref-deployment-info
branch
from
abe57a5 to
1273cc7
Compare
graphite-app
bot
removed
the
merge-queue
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOOL-2796 (XPROT-934)
Problem solved
This was an issue when installing modules published with ref contracts. Module installation goes through infra deployment functions which use computed addresses.
SDK should process ref contracts when computing published contract addresses.
PR-Codex overview
This PR focuses on enhancing the handling of published contract references within the
thirdweblibrary by modifying how contract addresses are computed and processed in deployment options.Detailed summary
processRefDeploymentsto handle empty salt values.computeRefDeploymentsto compute addresses for contract references.computeDeploymentInfoFromMetadatato use processed constructor parameters.