Skip to content

update startup program URL path #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 11, 2024

fixes: DASH-602


PR-Codex overview

This PR focuses on updating the routing paths in the apps/dashboard/framer-rewrites.js file by removing an outdated community page and adding a new startup program route.

Detailed summary

  • Removed the route "/community/ambassadors/startup-program".
  • Added the route "/community/startup-program".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 7b6e21f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 9:11pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 11, 2024 9:11pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 11, 2024 9:11pm
wallet-ui ⬜️ Skipped (Inspect) Dec 11, 2024 9:11pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 11, 2024 20:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 11, 2024 20:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 11, 2024 20:57 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 11, 2024
Copy link
Member Author

jnsdls commented Dec 11, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

linear bot commented Dec 11, 2024

@jnsdls jnsdls marked this pull request as ready for review December 11, 2024 20:58
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.54%. Comparing base (4573e2c) to head (7b6e21f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5701   +/-   ##
=======================================
  Coverage   51.54%   51.54%           
=======================================
  Files        1094     1094           
  Lines       57592    57592           
  Branches     4755     4755           
=======================================
  Hits        29686    29686           
  Misses      27188    27188           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4573e2c
packages 48.25% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 640 ms (+27.61% 🔺) 1.6 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 1.5 s (-4.74% 🔽) 3.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 30 ms (-34.65% 🔽) 142 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (-9.35% 🔽) 19 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 112 ms (+21.91% 🔺) 494 ms

Copy link
Contributor

graphite-app bot commented Dec 11, 2024

Merge activity

fixes: DASH-602

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the routing paths in the `framer-rewrites.js` file for the dashboard application, specifically modifying the community and grants sections.

### Detailed summary
- Removed the route `"/community/ambassadors/startup-program"`.
- Added the route `"/community/startup-program"`.
- No other changes were made to the routing paths for community pages or grants.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the update_startup_program_URL_path branch from 2c24a9a to 7b6e21f Compare December 11, 2024 21:08
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 11, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 11, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 11, 2024 21:08 Inactive
@graphite-app graphite-app bot merged commit 7b6e21f into main Dec 11, 2024
31 checks passed
@graphite-app graphite-app bot deleted the update_startup_program_URL_path branch December 11, 2024 21:12
@vercel vercel bot temporarily deployed to Production – wallet-ui December 11, 2024 21:12 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 11, 2024 21:12 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 11, 2024 21:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants