-
Notifications
You must be signed in to change notification settings - Fork 539
fix: Disable social profile request retries #5703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4b4ada4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5703 +/- ##
==========================================
+ Coverage 51.26% 51.53% +0.26%
==========================================
Files 1092 1094 +2
Lines 57375 57592 +217
Branches 4691 4756 +65
==========================================
+ Hits 29416 29681 +265
+ Misses 27243 27193 -50
- Partials 716 718 +2
*This pull request uses carry forward flags. Click here to find out more.
|
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on modifying the behavior of social profile requests in the
thirdweb
package by disabling the retry mechanism.Detailed summary
retry
option inuseSocialProfiles.ts
from3
tofalse
for social profile requests.enabled
condition to ensure it only runs whenaddress
is truthy.