Skip to content

fix: Disable social profile request retries #5703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 11, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on modifying the behavior of social profile requests in the thirdweb package by disabling the retry mechanism.

Detailed summary

  • Updated the retry option in useSocialProfiles.ts from 3 to false for social profile requests.
  • Adjusted the enabled condition to ensure it only runs when address is truthy.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:12pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:12pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:12pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:12pm

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 4b4ada4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 11, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 451 ms (+26.75% 🔺) 1.4 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 801 ms (-7.28% 🔽) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 30 ms (-62.25% 🔽) 141 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (-9.6% 🔽) 19 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 99 ms (+23.03% 🔺) 480 ms

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.53%. Comparing base (da5d8ec) to head (4b4ada4).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...hirdweb/src/react/core/social/useSocialProfiles.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5703      +/-   ##
==========================================
+ Coverage   51.26%   51.53%   +0.26%     
==========================================
  Files        1092     1094       +2     
  Lines       57375    57592     +217     
  Branches     4691     4756      +65     
==========================================
+ Hits        29416    29681     +265     
+ Misses      27243    27193      -50     
- Partials      716      718       +2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from da5d8ec
packages 48.24% <0.00%> (+0.34%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...hirdweb/src/react/core/social/useSocialProfiles.ts 11.11% <0.00%> (ø)

... and 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant