-
Notifications
You must be signed in to change notification settings - Fork 542
fix category page crash #5707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix category page crash #5707
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5707 +/- ##
=======================================
Coverage 51.53% 51.53%
=======================================
Files 1094 1094
Lines 57592 57592
Branches 4755 4755
=======================================
Hits 29681 29681
Misses 27193 27193
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
f548fae
to
7d201b6
Compare
size-limit report 📦
|
Merge activity
|
fixes: DASH-607 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on modifying the `explore` functionality by removing the export of `ALL_CATEGORIES` from `data/explore` and adjusting the import statements in `page.tsx`. ### Detailed summary - Removed the export of `ALL_CATEGORIES` from `apps/dashboard/src/data/explore.ts`. - Updated `apps/dashboard/src/app/(dashboard)/explore/[category]/page.tsx` to only import `getCategory` from `data/explore`, excluding `ALL_CATEGORIES`. - Deleted the `generateStaticParams` function that utilized `ALL_CATEGORIES`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
7d201b6
to
ce0da51
Compare
fixes: DASH-607
PR-Codex overview
This PR focuses on removing the usage of
ALL_CATEGORIES
from theexplore.ts
file and its import inpage.tsx
, along with the associatedgenerateStaticParams
function, which was responsible for generating static parameters based on all categories.Detailed summary
ALL_CATEGORIES
constant fromapps/dashboard/src/data/explore.ts
.generateStaticParams
function fromapps/dashboard/src/app/(dashboard)/explore/[category]/page.tsx
.page.tsx
to excludeALL_CATEGORIES
.