[Nebula] Fix page not redirected to new chat page when deleting active chat #5712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
requested review from
jnsdls,
joaquim-verges and
jakubkrehel
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5712 +/- ##
=======================================
Coverage 51.53% 51.53%
=======================================
Files 1094 1094
Lines 57592 57592
Branches 4755 4755
=======================================
Hits 29681 29681
Misses 27193 27193
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
jnsdls
approved these changes
Dec 12, 2024
MananTank
force-pushed
the
12-12-_nebula_remove_presence_message_when_adding_an_error_message
branch
2 times, most recently
from
9fbd0f0 to
6f04b6e
Compare
MananTank
force-pushed
the
12-12-_nebula_fix_page_not_redirected_to_new_chat_page_when_deleting_active_chat
branch
from
25c231a to
dfa5e52
Compare
MananTank
force-pushed
the
12-12-_nebula_remove_presence_message_when_adding_an_error_message
branch
from
6f04b6e to
2cb3c48
Compare
MananTank
force-pushed
the
12-12-_nebula_fix_page_not_redirected_to_new_chat_page_when_deleting_active_chat
branch
from
dfa5e52 to
b69f294
Compare
Merge activity
|
…e chat (#5712) Fixes: DASH-613 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the usage of the `newChatPageUrlStore` by introducing a custom hook, `useNewChatPageLink`, to manage the chat page URL more effectively across different components. ### Detailed summary - Added `useNewChatPageLink` hook in `useNewChatPageLink.ts` to retrieve the chat page URL. - Updated imports of `useNewChatPageLink` in `NebulaMobileNav.tsx`, `ChatSidebarLink.tsx`, and `ChatSidebar.tsx`. - Removed duplicate `useNewChatPageLink` function from `ChatSidebar.tsx`. - Set `newChatPageUrlStore` value directly in `ChatPageContent.tsx` based on the current page type. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
12-12-_nebula_remove_presence_message_when_adding_an_error_message
branch
from
2cb3c48 to
0842045
Compare
MananTank
force-pushed
the
12-12-_nebula_fix_page_not_redirected_to_new_chat_page_when_deleting_active_chat
branch
from
b69f294 to
f7e6041
Compare
Base automatically changed from
12-12-_nebula_remove_presence_message_when_adding_an_error_message
to
main
December 12, 2024 18:22
graphite-app
bot
deleted the
12-12-_nebula_fix_page_not_redirected_to_new_chat_page_when_deleting_active_chat
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DASH-613
PR-Codex overview
This PR focuses on refactoring the chat page link management by introducing the
useNewChatPageLinkhook and updating various components to use it, improving the code structure and maintainability.Detailed summary
useNewChatPageLinkhook inuseNewChatPageLink.ts.MobileNavto importuseNewChatPageLinkfrom hooks.ChatPageContentto set the chat page URL innewChatPageUrlStore.useNewChatPageLinkinChatSidebarLinkand adjusted navigation logic.useNewChatPageLinkfunction fromChatSidebar.