Skip to content

add onramp status for buy with fiat in portal #5713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Yash094
Copy link
Member

@Yash094 Yash094 commented Dec 12, 2024

Problem solved

added onramp status for buy with fiat in portal for dotnet.


PR-Codex overview

This PR adds a new section to the page.mdx file that outlines possible statuses for on-ramp transactions, providing clarity on various states that can occur during the transaction process.

Detailed summary

  • Added a <Details> element with a summary titled "OnRamp Status".
  • Included a heading ### OnRamp Status.
  • Listed possible statuses for on-ramp transactions in a code block, detailing each status and its meaning.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Yash094 Yash094 requested a review from a team as a code owner December 12, 2024 18:02
@Yash094 Yash094 requested a review from a team December 12, 2024 18:02
@Yash094 Yash094 requested a review from a team as a code owner December 12, 2024 18:02
Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 8c623c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented Dec 12, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 12, 2024 6:03pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 12, 2024 18:03 Inactive
Copy link

vercel bot commented Dec 12, 2024

@Yash094 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 12, 2024

### OnRamp Status

Possible status returned for a onramp transactions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor grammatical issue in this line. The text should read: Possible statuses returned for onramp transactions. This corrects both the singular/plural agreement of "status/statuses" and removes the unnecessary article "a" before "onramp".

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

PAYMENT_FAILED - Payment has failed.
PENDING_ON_RAMP_TRANSFER - Pending on-ramp transfer.
ON_RAMP_TRANSFER_IN_PROGRESS - On-ramp transfer is in progress.
ON_RAMP_TRANSFER_COMPLETED - On-ramp transfer is completed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a period after completed to maintain consistent punctuation with the other status descriptions.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@joaquim-verges joaquim-verges merged commit db6b0fc into thirdweb-dev:main Dec 13, 2024
22 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants