Skip to content

add onramp status for buy with fiat in portal #5713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

add onramp status for buy with fiat in portal #5713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/portal/src/app/dotnet/pay/getbuywithfiatstatus/page.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,26 @@ string FailureMessage; // Failure message if any
```

</Details>

<Details summary="OnRamp Status">

### OnRamp Status

Possible status returned for a onramp transactions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor grammatical issue in this line. The text should read: Possible statuses returned for onramp transactions. This corrects both the singular/plural agreement of "status/statuses" and removes the unnecessary article "a" before "onramp".

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.


```csharp
NONE - No status.
PENDING_PAYMENT - Payment is pending.
PAYMENT_FAILED - Payment has failed.
PENDING_ON_RAMP_TRANSFER - Pending on-ramp transfer.
ON_RAMP_TRANSFER_IN_PROGRESS - On-ramp transfer is in progress.
ON_RAMP_TRANSFER_COMPLETED - On-ramp transfer is completed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a period after completed to maintain consistent punctuation with the other status descriptions.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

ON_RAMP_TRANSFER_FAILED - On-ramp transfer has failed.
CRYPTO_SWAP_REQUIRED - Crypto swap is required.
CRYPTO_SWAP_COMPLETED - Crypto swap is completed.
CRYPTO_SWAP_FALLBACK - Crypto swap fallback.
CRYPTO_SWAP_IN_PROGRESS - Crypto swap is in progress.
CRYPTO_SWAP_FAILED - Crypto swap has failed.
```

</Details>
Loading