Skip to content

[Portal] Fix: Broken Link #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 12, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the href attribute in the page.mdx file to correct the link path for the "Getting started" guide related to thirdweb wallets.

Detailed summary

  • Changed the href from /wallet/get-started/overview to /connect/wallet/get-started.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested a review from a team as a code owner December 12, 2024 20:06
@gregfromstl gregfromstl requested a review from a team December 12, 2024 20:06
@gregfromstl gregfromstl requested a review from a team as a code owner December 12, 2024 20:06
Copy link

linear bot commented Dec 12, 2024

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: bc368c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 8:42pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 12, 2024 8:42pm
thirdweb-www ⬜️ Skipped (Inspect) Dec 12, 2024 8:42pm
wallet-ui ⬜️ Skipped (Inspect) Dec 12, 2024 8:42pm

Copy link
Contributor

graphite-app bot commented Dec 12, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.65%. Comparing base (19487cb) to head (bc368c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5716   +/-   ##
=======================================
  Coverage   51.65%   51.65%           
=======================================
  Files        1097     1097           
  Lines       57788    57788           
  Branches     4773     4773           
=======================================
  Hits        29853    29853           
  Misses      27217    27217           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 19487cb
packages 48.40% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 12, 2024
Copy link
Member Author

gregfromstl commented Dec 12, 2024

Merge activity

  • Dec 12, 3:07 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 12, 3:34 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 12, 3:43 PM EST: A user merged this pull request with the Graphite merge queue.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 1.2 s (-7.47% 🔽) 2.1 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 2.8 s (+16.75% 🔺) 5.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 58 ms (-8.81% 🔽) 170 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 52 ms (+53.06% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 272 ms (+25.9% 🔺) 653 ms

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the link in the `page.mdx` file for the wallet overview section, directing users to the correct "get started" guide for thirdweb wallets.

### Detailed summary
- Changed the `href` attribute from `/wallet/get-started/overview` to `/connect/wallet/get-started` in the `page.mdx` file.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/cnct-2651-fix-broken-getting-started-link-on-thirdweb-wallet-page branch from f8c1657 to bc368c5 Compare December 12, 2024 20:35
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 12, 2024 20:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 12, 2024 20:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 12, 2024 20:35 Inactive
@graphite-app graphite-app bot merged commit bc368c5 into main Dec 12, 2024
32 checks passed
@graphite-app graphite-app bot deleted the greg/cnct-2651-fix-broken-getting-started-link-on-thirdweb-wallet-page branch December 12, 2024 20:43
@vercel vercel bot temporarily deployed to Production – wallet-ui December 12, 2024 20:43 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 12, 2024 20:43 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www December 12, 2024 20:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants