Skip to content

[Service Utils] Feature: Adds analytics and social service definitions #5721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 13, 2024

PR-Codex overview

This PR introduces new definitions for analytics and social services in the service-utils package, enhancing the functionality for tracking usage and retrieving social data across decentralized protocols.

Detailed summary

  • Added analytics service with properties: name, title, description, and actions.
  • Added social service with properties: name, title, description, and actions.
  • Updated SERVICE_NAMES to include the new services.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 13, 2024

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 1ef8fb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:47am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:47am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:47am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:47am

Copy link
Contributor

graphite-app bot commented Dec 13, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.85%. Comparing base (64f4103) to head (1ef8fb5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5721   +/-   ##
=======================================
  Coverage   52.85%   52.85%           
=======================================
  Files        1098     1098           
  Lines       58976    58976           
  Branches     4788     4788           
=======================================
  Hits        31173    31173           
  Misses      27087    27087           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 64f4103
packages 49.95% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 405 ms (+57.12% 🔺) 1.4 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 973 ms (+26.87% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 212 ms (+864.51% 🔺) 324 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 54 ms (+1030.4% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 201 ms (+80.99% 🔺) 582 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant