Skip to content

Remove pre-release script and simplify release workflows #5726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 13, 2024

pnpm release already builds packages and bun is not used in the release flow

Changes

  • Removed redundant build steps from release workflows since the changesets action handles this
  • Removed bun setup from release workflows as it's not used
  • Removed pre-release.mjs script that is no longer needed
  • Updated build:release command in package.json to use turbo directly

PR-Codex overview

This PR focuses on updating the GitHub Actions workflows and package scripts for building and releasing the project. It removes the release-nightly.yml workflow and modifies the build commands to streamline the process.

Detailed summary

  • Deleted scripts/pre-release.mjs.github/workflows/release-nightly.yml.
  • Modified build commands in workflows to use pnpm build instead of pnpm build:packages.
  • Updated build:release script in package.json to use turbo run build instead of pnpm run build.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: c92a9a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 5:24am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 5:24am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 5:24am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 5:24am

@jnsdls jnsdls marked this pull request as ready for review December 13, 2024 05:14
Copy link
Member Author

jnsdls commented Dec 13, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.85%. Comparing base (aa72ba2) to head (c92a9a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5726   +/-   ##
=======================================
  Coverage   52.85%   52.85%           
=======================================
  Files        1098     1098           
  Lines       58976    58976           
  Branches     4788     4788           
=======================================
  Hits        31173    31173           
  Misses      27087    27087           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from aa72ba2
packages 49.95% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 513 ms (+28.87% 🔺) 1.5 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 1.1 s (+1.82% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 202 ms (+217.8% 🔺) 313 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 37 ms (+422.28% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 229 ms (+120.22% 🔺) 610 ms

@jnsdls jnsdls force-pushed the 12-12-simplify_publish_github_actions branch from b52482d to 3a54059 Compare December 13, 2024 05:19
@jnsdls jnsdls changed the title simplify publish github actions Remove pre-release script and simplify release workflows Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant