Process deploy param ref only when non-empty #5730

kumaryash90 · 2024-12-13T09:05:03Z

PROT-935

PR-Codex overview

This PR focuses on improving the handling of implementationConstructorParams and initializeParams by adding checks to ensure they are defined before processing, enhancing code safety and readability.

Detailed summary

Changed processedImplParams and processedInitializeParams to be undefined initially.
Added checks for implementationConstructorParams and initializeParams to ensure they are defined before processing.
Retained the logic for processing parameters within the respective conditionals.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-12-13T09:05:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 9:19am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 9:19am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 9:19am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 9:19am

changeset-bot · 2024-12-13T09:05:10Z

⚠️ No Changeset found

Latest commit: 8761fe6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-12-13T09:05:10Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2024-12-13T09:09:05Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	44.94 KB (0%)	899 ms (0%)	400 ms (+125.46% 🔺)	1.3 s
thirdweb (cjs)	110.78 KB (0%)	2.3 s (0%)	546 ms (-23.86% 🔽)	2.8 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	51 ms (+132.16% 🔺)	163 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	25 ms (+554.67% 🔺)	35 ms
thirdweb/react (minimal + tree-shaking)	19.03 KB (0%)	381 ms (0%)	72 ms (+3.51% 🔺)	453 ms

codecov · 2024-12-13T09:10:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.93%. Comparing base (77c8d0e) to head (8761fe6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5730      +/-   ##
==========================================
+ Coverage   52.92%   52.93%   +0.01%     
==========================================
  Files        1098     1098              
  Lines       58976    58982       +6     
  Branches     4794     4794              
==========================================
+ Hits        31212    31225      +13     
+ Misses      27046    27039       -7     
  Partials      718      718

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 77c8d0e
packages	`50.05% <100.00%> (+0.02%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...rdweb/src/extensions/prebuilts/deploy-published.ts	`84.18% <100.00%> (+3.21%)`	⬆️

joaquim-verges · 2024-12-13T09:15:49Z

Merge activity

Dec 13, 4:15 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 13, 4:15 AM EST: A user added this pull request to the Graphite merge queue.
Dec 13, 4:19 AM EST: A user merged this pull request with the Graphite merge queue.

PROT-935  --- ## PR-Codex overview This PR focuses on enhancing the handling of `implementationConstructorParams` and `initializeParams` by adding null checks to ensure that they are defined before processing. This improves the robustness of the code. ### Detailed summary - Changed `processedImplParams` and `processedInitializeParams` from constants to `undefined` initially. - Added checks to confirm that `implementationConstructorParams` and `initializeParams` are defined before processing. - Retained the logic for processing parameters using `processRefDeployments`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

kumaryash90 requested review from joaquim-verges, gregfromstl and jnsdls as code owners December 13, 2024 09:05

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 13, 2024

github-actions bot assigned kumaryash90 Dec 13, 2024

vercel bot deployed to Preview – wallet-ui December 13, 2024 09:06 View deployment

vercel bot deployed to Preview – thirdweb_playground December 13, 2024 09:06 View deployment

vercel bot deployed to Preview – docs-v2 December 13, 2024 09:11 View deployment

vercel bot deployed to Preview – thirdweb-www December 13, 2024 09:13 View deployment

joaquim-verges approved these changes Dec 13, 2024

View reviewed changes

joaquim-verges added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 13, 2024

joaquim-verges force-pushed the yash/fix-deploy-param-resolution branch from 7879318 to 8761fe6 Compare December 13, 2024 09:16

vercel bot deployed to Preview – wallet-ui December 13, 2024 09:17 View deployment

vercel bot deployed to Preview – thirdweb_playground December 13, 2024 09:17 View deployment

vercel bot deployed to Preview – docs-v2 December 13, 2024 09:18 View deployment

vercel bot deployed to Preview – thirdweb-www December 13, 2024 09:19 View deployment

graphite-app bot merged commit 8761fe6 into main Dec 13, 2024
31 checks passed

graphite-app bot deleted the yash/fix-deploy-param-resolution branch December 13, 2024 09:19

vercel bot deployed to Production – wallet-ui December 13, 2024 09:21 View deployment

vercel bot deployed to Production – thirdweb_playground December 13, 2024 09:21 View deployment

vercel bot deployed to Production – docs-v2 December 13, 2024 09:21 View deployment

vercel bot deployed to Production – thirdweb-www December 13, 2024 09:27 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Process deploy param ref only when non-empty #5730

Process deploy param ref only when non-empty #5730

Uh oh!

kumaryash90 commented Dec 13, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Dec 13, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 13, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024 •

edited

Loading

Uh oh!

codecov bot commented Dec 13, 2024 •

edited

Loading

Uh oh!

joaquim-verges commented Dec 13, 2024 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Uh oh!

Process deploy param ref only when non-empty #5730

Process deploy param ref only when non-empty #5730

Uh oh!

Conversation

kumaryash90 commented Dec 13, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Dec 13, 2024

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joaquim-verges commented Dec 13, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

kumaryash90 commented Dec 13, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 13, 2024 •

edited

Loading

changeset-bot bot commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading

codecov bot commented Dec 13, 2024 •

edited

Loading

joaquim-verges commented Dec 13, 2024 •

edited by graphite-app bot

Loading