Skip to content

docs: Add more context on guest mode #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

roninjin10
Copy link
Contributor

@roninjin10 roninjin10 commented Dec 13, 2024

Guest mode docs were not very clear to me. This changes the docs to how I think it works filling in the blanks

Problem solved

Improve docs for guest mode


PR-Codex overview

This PR enhances the documentation for the Guest Mode feature in the app, providing additional context on how it functions and its temporary nature.

Detailed summary

  • Expanded the description of Guest Mode to include that it allows users to start without signing in.
  • Clarified that the guest mode account is not persisted and only exists in memory until linked to an Auth method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Guest mode docs were not very clear to me. This changes the docs to how I think it works filling in the blanks

Signed-off-by: Will Cory <willcory10@gmail.com>
@roninjin10 roninjin10 requested a review from a team as a code owner December 13, 2024 17:33
@roninjin10 roninjin10 requested a review from a team December 13, 2024 17:33
@roninjin10 roninjin10 requested a review from a team as a code owner December 13, 2024 17:33
Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: acf73dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented Dec 13, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

vercel bot commented Dec 13, 2024

@roninjin10 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 13, 2024
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 5:41pm

@jnsdls jnsdls merged commit be6433d into thirdweb-dev:main Dec 13, 2024
23 of 30 checks passed
@@ -20,7 +20,7 @@ export const metadata = createMetadata({

# Guest Mode

Sometimes users want to get started using your app without signing in. You can now give users an in-memory "guest account" that can then be converted into a standard account by linking another auth method.
Sometimes users want to get started using your app without signing in. You can now give users an in-memory "guest account" that can then be converted into a standard account by linking another auth method. An example is if you want to wait til a user tries to make a transaction before forcing them to onboard. A guest mode account is not persisted durably and only exists in memory until linked to an Auth method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually on the web it persists the session id to local storage, so you don't loose it on page reload

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is react native different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants