Skip to content

use resolved ENS name if available #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 13, 2024

fixes: DASH-572


PR-Codex overview

This PR focuses on enhancing the ProfileUI and ProfileHeader components by adding the ensName property, improving how the ENS name is displayed. It also updates the dev script in package.json to use the Turbo feature and modifies a comment in next-env.d.ts.

Detailed summary

  • In page.tsx, ensName is now set using replaceDeployerAddress.
  • The ProfileHeader component now accepts ensName as a prop.
  • In ProfileHeader, the ENS name is conditionally displayed if available.
  • The dev script in package.json has been updated to use --turbo.
  • Updated the comment in next-env.d.ts for clarity on TypeScript configuration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 80b54a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:17pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 13, 2024 6:17pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 13, 2024 6:17pm
wallet-ui ⬜️ Skipped (Inspect) Dec 13, 2024 6:17pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 17:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 17:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 17:58 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 13, 2024
Copy link

linear bot commented Dec 13, 2024

Copy link
Member Author

jnsdls commented Dec 13, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review December 13, 2024 17:58
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.89%. Comparing base (be6433d) to head (80b54a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5734   +/-   ##
=======================================
  Coverage   52.89%   52.89%           
=======================================
  Files        1099     1099           
  Lines       59010    59010           
  Branches     4791     4791           
=======================================
  Hits        31211    31211           
  Misses      27083    27083           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from be6433d
packages 49.99% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 718 ms (+73.61% 🔺) 1.7 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 1.1 s (+5.9% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 80 ms (+188.2% 🔺) 192 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+601.35% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 125 ms (+100.63% 🔺) 505 ms

Copy link
Contributor

graphite-app bot commented Dec 13, 2024

Merge activity

@jnsdls jnsdls force-pushed the 12-13-use_resolved_ens_name_if_available branch from 9ccc3ea to 80b54a9 Compare December 13, 2024 18:14
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 18:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 18:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 18:14 Inactive
@graphite-app graphite-app bot merged commit 80b54a9 into main Dec 13, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 12-13-use_resolved_ens_name_if_available branch December 13, 2024 18:17
@vercel vercel bot temporarily deployed to Production – wallet-ui December 13, 2024 18:17 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 13, 2024 18:17 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 13, 2024 18:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants