Skip to content

[CI] Chore: Update allowed teams #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 13, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the environment variable VALID_ISSUE_PREFIXES in the .github/workflows/issue.yml file to include additional prefixes for issue validation.

Detailed summary

  • Updated VALID_ISSUE_PREFIXES to include: ENGINE, CS, DES, BIL, DEVX, SOLU, and NEB.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 13, 2024

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: ba52fe6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:30pm
thirdweb_playground 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:30pm
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:30pm
wallet-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:30pm

Copy link
Contributor

graphite-app bot commented Dec 13, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl merged commit 22bc557 into main Dec 13, 2024
9 of 13 checks passed
@gregfromstl gregfromstl deleted the greg/cnct-2654-js-ci-reduce-issue-strictness branch December 13, 2024 18:31
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.89%. Comparing base (f7e6041) to head (ba52fe6).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5735      +/-   ##
==========================================
+ Coverage   51.53%   52.89%   +1.35%     
==========================================
  Files        1094     1099       +5     
  Lines       57592    59010    +1418     
  Branches     4755     4791      +36     
==========================================
+ Hits        29681    31211    +1530     
+ Misses      27193    27083     -110     
+ Partials      718      716       -2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f7e6041
packages 49.99% <ø> (+1.75%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 20 files with indirect coverage changes

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 1.5 s (-5.05% 🔽) 2.4 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 4 s (+17.68% 🔺) 6.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 75 ms (-76.26% 🔽) 186 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 100 ms (+318.19% 🔺) 110 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 247 ms (-11.29% 🔽) 627 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant