Fix API key redirect URL schema on in-app wallet settings and unresponsive general project settings page #5747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
requested review from
jnsdls,
joaquim-verges and
jakubkrehel
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
MananTank
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5747 +/- ##
=======================================
Coverage 53.01% 53.01%
=======================================
Files 1101 1101
Lines 59079 59079
Branches 4806 4806
=======================================
Hits 31318 31318
Misses 27043 27043
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
MananTank
force-pushed
the
12-16-fix_api_key_redirect_url_on_in-app_wallet_settings_and_unresponsive_general_project_settings_page
branch
from
4c36f40 to
3f5fec7
Compare
MananTank
force-pushed
the
12-16-fix_api_key_redirect_url_on_in-app_wallet_settings_and_unresponsive_general_project_settings_page
branch
from
3f5fec7 to
fd6fa64
Compare
jnsdls
approved these changes
Dec 16, 2024
Merge activity
|
…nsive general project settings page (#5747) ## Problem solved Fixes: DASH-629 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the validation schema and related components for project settings, particularly around custom authentication endpoints and redirect URIs. The changes enhance the form handling and validation logic in the dashboard. ### Detailed summary - Introduced `expandCustomAuthEndpointField` for conditional rendering of custom authentication endpoint fields. - Updated `checked` property of `GatedSwitch` to use the new variable. - Modified the placeholder of `Textarea` in `NativeAppsFieldset`. - Changed `UpdateAPIForm` type to use `ProjectSettingsPageFormSchema`. - Updated form initialization to use `projectSettingsPageFormSchema`. - Refined validation logic for redirect URIs, allowing specific formats. - Created a new `redirectUriSchema` for validating redirect URIs. - Updated `redirectUrls` validation to use the new schema. - Changed the exported validation type from `ApiKeyValidationSchema` to `ProjectSettingsPageFormSchema`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
12-16-fix_api_key_redirect_url_on_in-app_wallet_settings_and_unresponsive_general_project_settings_page
branch
from
fd6fa64 to
f1cf2fa
Compare
graphite-app
bot
deleted the
12-16-fix_api_key_redirect_url_on_in-app_wallet_settings_and_unresponsive_general_project_settings_page
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Fixes: DASH-629
PR-Codex overview
This PR focuses on refactoring and enhancing the validation logic for project settings, specifically regarding API key management and redirect URIs. It introduces a new schema for project settings and modifies the handling of advanced features in the
embedded-walletscomponent.Detailed summary
expandCustomAuthEndpointFieldto manage the visibility of custom auth endpoint settings.showprop inAdvancedConfigurationContainerto useexpandCustomAuthEndpointField.UpdateAPIFormtype to useProjectSettingsPageFormSchema.projectSettingsPageFormSchemafor project settings validation.isValidRedirectURIfunction to validate redirect URIs.redirectUrlsvalidation to use the newredirectUriSchema.