Remove duplicated in-app-wallet and account-abstraction settings UI from /connect layout #5748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
requested review from
jnsdls,
joaquim-verges and
jakubkrehel
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5748 +/- ##
=======================================
Coverage 53.01% 53.01%
=======================================
Files 1101 1101
Lines 59079 59079
Branches 4806 4806
=======================================
Hits 31318 31318
Misses 27043 27043
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
MananTank
changed the base branch from
12-16-fix_api_key_redirect_url_on_in-app_wallet_settings_and_unresponsive_general_project_settings_page
to
graphite-base/5748
MananTank
force-pushed
the
graphite-base/5748
branch
from
fd6fa64 to
f1cf2fa
Compare
MananTank
force-pushed
the
12-16-remove_duplicated_in-app-wallet_and_account-abstraction_settings_ui_from__connect_layout
branch
from
b5a841c to
9e731be
Compare
MananTank
force-pushed
the
12-16-remove_duplicated_in-app-wallet_and_account-abstraction_settings_ui_from__connect_layout
branch
from
9e731be to
cf93956
Compare
jnsdls
approved these changes
Dec 16, 2024
Merge activity
|
…rom /connect layout (#5748) ## Problem solved Fixes: DASH-630 In-App wallet and Account abstraction settings are already available in project settings layout <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on refactoring the `AccountAbstractionPage` and `SmartWallets` components by removing the `twAccount` property and associated logic, along with deleting unused configuration files. It streamlines the code and improves maintainability. ### Detailed summary - Deleted files: `page.tsx` and `loading.tsx` in `connect/in-app-wallets/config`. - Removed `twAccount` property from `AccountAbstractionPage` and `SmartWallets` components. - Updated `AccountAbstractionPage` to only fetch `team` and `project` data. - Removed `getValidAccount` function call. - Deleted `Sponsorship Policies` tab and related logic from `SmartWallets`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
12-16-remove_duplicated_in-app-wallet_and_account-abstraction_settings_ui_from__connect_layout
branch
from
cf93956 to
b173ad2
Compare
graphite-app
bot
deleted the
12-16-remove_duplicated_in-app-wallet_and_account-abstraction_settings_ui_from__connect_layout
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Fixes: DASH-630
In-App wallet and Account abstraction settings are already available in project settings layout
PR-Codex overview
This PR primarily focuses on removing the
Configurationsection from the in-app wallets feature and refactoring theAccountAbstractionPageandSmartWalletscomponents to eliminate the dependency onAccountandApiKeyService, streamlining the code.Detailed summary
page.tsxandloading.tsxfromconnect/in-app-wallets/config.Configurationentry from the routing setup.twAccountfromAccountAbstractionPageprops.page.tsxby removinggetValidAccount.twAccountfromSmartWalletsPropsinterface and its usage inSmartWallets.Sponsorship Policiestab fromSmartWalletscomponent.